|
|
DescriptionRemove boolean-based WaitableEvent constructor.
BUG=612843
TBR=danakj@chromium.org
Committed: https://crrev.com/d9aa1d1595be22ea06a83eb6216414cebae6b2e8
Cr-Commit-Position: refs/heads/master@{#398959}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 35 (18 generated)
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
gab@chromium.org changed reviewers: + danakj@chromium.org
Dana PTAL, I will TBR this the minute it's green (happy to do follow-up for any post-commit comments just don't want new usage of old constructor to sneak in!)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
Description was changed from ========== Remove boolean-based WaitableEvent constructor. BUG=612843 ========== to ========== Remove boolean-based WaitableEvent constructor. BUG=612843 TBR=danakj@chromium.org ==========
gab@chromium.org changed reviewers: + fdoray@chromium.org
Francois PTAL, I'll TBR Dana in order to land this while it's green (if it does turn green that is!)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM! https://codereview.chromium.org/2030683005/diff/40001/base/synchronization/wa... File base/synchronization/waitable_event_posix.cc (right): https://codereview.chromium.org/2030683005/diff/40001/base/synchronization/wa... base/synchronization/waitable_event_posix.cc:46: WaitableEvent::~WaitableEvent() = default; thanks :)
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
Message was sent while issue was closed.
Description was changed from ========== Remove boolean-based WaitableEvent constructor. BUG=612843 TBR=danakj@chromium.org ========== to ========== Remove boolean-based WaitableEvent constructor. BUG=612843 TBR=danakj@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Remove boolean-based WaitableEvent constructor. BUG=612843 TBR=danakj@chromium.org ========== to ========== Remove boolean-based WaitableEvent constructor. BUG=612843 TBR=danakj@chromium.org Committed: https://crrev.com/d9aa1d1595be22ea06a83eb6216414cebae6b2e8 Cr-Commit-Position: refs/heads/master@{#398959} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d9aa1d1595be22ea06a83eb6216414cebae6b2e8 Cr-Commit-Position: refs/heads/master@{#398959} |