Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2030683005: Remove boolean-based WaitableEvent constructor. (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj, fdoray
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome_thread_watcher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove boolean-based WaitableEvent constructor. BUG=612843 TBR=danakj@chromium.org Committed: https://crrev.com/d9aa1d1595be22ea06a83eb6216414cebae6b2e8 Cr-Commit-Position: refs/heads/master@{#398959}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -31 lines) Patch
M base/synchronization/waitable_event.h View 2 chunks +1 line, -9 lines 0 comments Download
M base/synchronization/waitable_event_posix.cc View 2 chunks +8 lines, -15 lines 1 comment Download
M base/synchronization/waitable_event_win.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 35 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
4 years, 6 months ago (2016-06-07 21:59:26 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/149382)
4 years, 6 months ago (2016-06-07 22:13:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
4 years, 6 months ago (2016-06-08 22:42:58 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/124496) mac_chromium_rel_ng on ...
4 years, 6 months ago (2016-06-08 22:56:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
4 years, 6 months ago (2016-06-09 12:15:12 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/150560)
4 years, 6 months ago (2016-06-09 12:29:40 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
4 years, 6 months ago (2016-06-09 14:51:31 UTC) #16
gab
Dana PTAL, I will TBR this the minute it's green (happy to do follow-up for ...
4 years, 6 months ago (2016-06-09 14:53:08 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/150598)
4 years, 6 months ago (2016-06-09 15:06:45 UTC) #20
gab
Francois PTAL, I'll TBR Dana in order to land this while it's green (if it ...
4 years, 6 months ago (2016-06-09 17:26:10 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
4 years, 6 months ago (2016-06-09 17:26:44 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 18:08:19 UTC) #27
danakj
LGTM! https://codereview.chromium.org/2030683005/diff/40001/base/synchronization/waitable_event_posix.cc File base/synchronization/waitable_event_posix.cc (right): https://codereview.chromium.org/2030683005/diff/40001/base/synchronization/waitable_event_posix.cc#newcode46 base/synchronization/waitable_event_posix.cc:46: WaitableEvent::~WaitableEvent() = default; thanks :)
4 years, 6 months ago (2016-06-09 18:25:45 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683005/40001
4 years, 6 months ago (2016-06-09 18:27:48 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 6 months ago (2016-06-09 18:41:36 UTC) #32
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 18:41:45 UTC) #33
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 18:46:17 UTC) #35
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9aa1d1595be22ea06a83eb6216414cebae6b2e8
Cr-Commit-Position: refs/heads/master@{#398959}

Powered by Google App Engine
This is Rietveld 408576698