Don't pick a drop operation that the source doesn't support.

Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's defaultOperationForDrag() makes an attempt to choose a reasonable operation based on what the source supports.

Unfortunately, if the source supports "generic" but not move, defaultOperationForDrag() chooses an operation that the source doesn't support, and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Committed: https://crrev.com/57b70dae30c2bc7d60e70efd8ebae83e01fe9119
Cr-Commit-Position: refs/heads/master@{#404885}

[Avi (use Gerrit), 2016-06-01 20:43:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 20:43:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2030683003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2030683003/1

[commit-bot: I haz the power, 2016-06-01 22:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 22:46:07]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-06-02 18:23:12]

Description was changed from

==========
Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's
defaultOperationForDrag() makes an attempt to choose a reasonable operation
based on what the source supports.

Unfortunately, if the source supports "generic" but not move,
defaultOperationForDrag() chooses an operation that the source doesn't support,
and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
==========

to

==========
Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's
defaultOperationForDrag() makes an attempt to choose a reasonable operation
based on what the source supports.

Unfortunately, if the source supports "generic" but not move,
defaultOperationForDrag() chooses an operation that the source doesn't support,
and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[Avi (use Gerrit), 2016-06-02 19:57:58]

avi@chromium.org changed reviewers:
+ dcheng@chromium.org

[Avi (use Gerrit), 2016-07-11 18:32:25]

ping

[dcheng, 2016-07-12 06:55:30]

Meh. It looks like generic is some OS X concept that we have to awkwardly
account for in the web platform.

LGTM, the tests are passing so hopefully it doesn't break anything.

[Avi (use Gerrit), 2016-07-12 13:37:02]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-07-12 13:37:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:06:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-07-12 15:07:56]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:08:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:52:50]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[Avi (use Gerrit), 2016-07-12 17:08:19]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-07-12 17:09:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 20:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:55:21]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-07-12 23:12:36]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-07-12 23:14:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:45:47]

Description was changed from

==========
Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's
defaultOperationForDrag() makes an attempt to choose a reasonable operation
based on what the source supports.

Unfortunately, if the source supports "generic" but not move,
defaultOperationForDrag() chooses an operation that the source doesn't support,
and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's
defaultOperationForDrag() makes an attempt to choose a reasonable operation
based on what the source supports.

Unfortunately, if the source supports "generic" but not move,
defaultOperationForDrag() chooses an operation that the source doesn't support,
and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[commit-bot: I haz the power, 2016-07-13 01:45:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 01:47:18]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 01:48:58]

Description was changed from

==========
Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's
defaultOperationForDrag() makes an attempt to choose a reasonable operation
based on what the source supports.

Unfortunately, if the source supports "generic" but not move,
defaultOperationForDrag() chooses an operation that the source doesn't support,
and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
Don't pick a drop operation that the source doesn't support.

If a page doesn't specify a drop operation, DragController's
defaultOperationForDrag() makes an attempt to choose a reasonable operation
based on what the source supports.

Unfortunately, if the source supports "generic" but not move,
defaultOperationForDrag() chooses an operation that the source doesn't support,
and the drop fails.

Fix it by not returning "move" if it is not supported.

BUG=610085
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Committed: https://crrev.com/57b70dae30c2bc7d60e70efd8ebae83e01fe9119
Cr-Commit-Position: refs/heads/master@{#404885}
==========

[commit-bot: I haz the power, 2016-07-13 01:48:59]

Patchset 1 (id:??) landed as
https://crrev.com/57b70dae30c2bc7d60e70efd8ebae83e01fe9119
Cr-Commit-Position: refs/heads/master@{#404885}