Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2030683002: Update typeface serialization style. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clang has good warnings. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M include/core/SkPicture.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkFontDescriptor.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkFontDescriptor.cpp View 1 3 chunks +12 lines, -3 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontMgr_custom.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkWhitelistTypefaces.cpp View 5 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030683002/1
4 years, 6 months ago (2016-06-01 19:38:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/8812)
4 years, 6 months ago (2016-06-01 19:46:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030683002/20001
4 years, 6 months ago (2016-06-01 20:00:31 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 20:19:18 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683002/40001
4 years, 6 months ago (2016-06-13 15:07:51 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 15:24:32 UTC) #13
bungeman-skia
4 years, 6 months ago (2016-06-13 15:51:44 UTC) #15
reed1
lgtm
4 years, 6 months ago (2016-06-13 17:22:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030683002/40001
4 years, 6 months ago (2016-06-13 17:33:49 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17
4 years, 6 months ago (2016-06-13 17:35:08 UTC) #20
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2067583002/ by mtklein@google.com. ...
4 years, 6 months ago (2016-06-13 18:27:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2030683002/40001
4 years, 5 months ago (2016-07-25 23:37:03 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 23:55:04 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b8113780c3cfed640016b263194b7f1531d43312

Powered by Google App Engine
This is Rietveld 408576698