Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2030673002: New benchmark to measure GPU mip-mapping performance (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

New benchmark to measure GPU mip-mapping performance BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030673002 Committed: https://skia.googlesource.com/skia/+/fc29906826717528aa22e58fa9df8ba68cb3de9e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A bench/GrMipMapBench.cpp View 1 chunk +74 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (6 generated)
Brian Osman
4 years, 6 months ago (2016-06-01 19:16:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030673002/1
4 years, 6 months ago (2016-06-01 19:16:57 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 19:34:52 UTC) #7
bsalomon
lgtm https://codereview.chromium.org/2030673002/diff/1/bench/GrMipMapBench.cpp File bench/GrMipMapBench.cpp (right): https://codereview.chromium.org/2030673002/diff/1/bench/GrMipMapBench.cpp#newcode36 bench/GrMipMapBench.cpp:36: if (nullptr == context) { you can just ...
4 years, 6 months ago (2016-06-01 19:37:29 UTC) #8
Brian Osman
FYI: On my laptop's Quadro, my manual mipmap code is faster than the driver's in ...
4 years, 6 months ago (2016-06-01 19:38:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030673002/1
4 years, 6 months ago (2016-06-01 19:39:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fc29906826717528aa22e58fa9df8ba68cb3de9e
4 years, 6 months ago (2016-06-01 19:40:19 UTC) #13
bsalomon
4 years, 6 months ago (2016-06-01 19:49:47 UTC) #14
Message was sent while issue was closed.
On 2016/06/01 19:38:56, Brian Osman wrote:
> FYI: On my laptop's Quadro, my manual mipmap code is faster than the driver's
in
> this test (171 vs 139 in the Even/Odd and Odd/Even tests, and 260 vs 131 in
the
> Odd/Odd test). :)

Wow, that's surprising!

Powered by Google App Engine
This is Rietveld 408576698