Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2030583002: [Interpreter] Don't try to eliminate dead-code in bytecode-array-builder (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Don't try to eliminate dead-code in bytecode-array-builder Eliminating dead code in the bytecode array builder doesn't play nice with the register elimination optimizer. We should move it to it's own stage in the optimization pipeline, however doing so would require refactoring of how we deal with jumps, so for now just remove the dead code elimination optimization. BUG=chromium:616064 Committed: https://crrev.com/2fd3f9d69b20b1a6fb4fcaae213560380fd8ef33 Cr-Commit-Position: refs/heads/master@{#36660}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix Test #

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030583002/1
4 years, 6 months ago (2016-06-01 15:41:21 UTC) #2
rmcilroy
Mythri, PTAL, thanks.
4 years, 6 months ago (2016-06-01 15:41:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2465) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-01 15:55:21 UTC) #6
mythria
lgtm.
4 years, 6 months ago (2016-06-01 15:57:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030583002/20001
4 years, 6 months ago (2016-06-01 16:13:37 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/2542) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-01 16:45:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030583002/40001
4 years, 6 months ago (2016-06-01 20:07:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/6615)
4 years, 6 months ago (2016-06-01 22:14:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030583002/40001
4 years, 6 months ago (2016-06-01 22:21:38 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-01 22:54:46 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 22:55:27 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2fd3f9d69b20b1a6fb4fcaae213560380fd8ef33
Cr-Commit-Position: refs/heads/master@{#36660}

Powered by Google App Engine
This is Rietveld 408576698