Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt

Issue 203053002: Add null check for frame when creating WebCore::Performance. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add rebaseline expectations Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
diff --git a/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt b/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
similarity index 67%
copy from LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
copy to LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
index 51647f0cdd792ec305f8f49e1715690be6b2c40a..728017f50bd5b9ba768e3d050d828faf0b18bcdf 100644
--- a/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
+++ b/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
@@ -1,5 +1,5 @@
CONSOLE WARNING: 'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.
-Tests property access on a cached DOMWindow after the associated frame is no longer in a web page. Test should not crash and properties should be set to sane defaults.
+Tests property access on a cached DOMWindow after the associated frame is removed from a web page and garbage collected. Test should not crash and properties should be set to sane defaults.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -8,20 +8,21 @@ PASS childWindow.devicePixelRatio is 0
PASS childWindow.history.length is 0
PASS childWindow.innerHeight is 0
PASS childWindow.innerWidth is 0
+FAIL childWindow.jsTestIsAsync should be false (of type boolean). Was undefined (of type undefined).
PASS childWindow.length is 0
-PASS childWindow.location.href is 'about:blank'
-PASS childWindow.location.origin is 'null'
-PASS childWindow.location.pathname is 'blank'
-PASS childWindow.location.protocol is 'about:'
+FAIL childWindow.location.href should be about:blank (of type string). Was undefined (of type undefined).
+FAIL childWindow.location.origin should be null (of type string). Was undefined (of type undefined).
+FAIL childWindow.location.pathname should be blank (of type string). Was undefined (of type undefined).
+FAIL childWindow.location.protocol should be about: (of type string). Was undefined (of type undefined).
PASS childWindow.locationbar.visible is false
PASS childWindow.menubar.visible is false
PASS childWindow.navigator.appCodeName is window.navigator.appCodeName
PASS childWindow.navigator.appName is window.navigator.appName
PASS childWindow.navigator.appVersion is ''
-PASS childWindow.navigator.battery.charging is true
-PASS childWindow.navigator.battery.chargingTime is Infinity
-PASS childWindow.navigator.battery.dischargingTime is Infinity
-PASS childWindow.navigator.battery.level is 1
+FAIL childWindow.navigator.battery.charging should be false. Threw exception TypeError: Cannot read property 'charging' of null
+FAIL childWindow.navigator.battery.chargingTime should be 0. Threw exception TypeError: Cannot read property 'chargingTime' of null
+FAIL childWindow.navigator.battery.dischargingTime should be 0. Threw exception TypeError: Cannot read property 'dischargingTime' of null
+FAIL childWindow.navigator.battery.level should be 0. Threw exception TypeError: Cannot read property 'level' of null
PASS childWindow.navigator.cookieEnabled is false
PASS childWindow.navigator.language is window.navigator.language
PASS childWindow.navigator.onLine is window.navigator.onLine

Powered by Google App Engine
This is Rietveld 408576698