Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 20305004: Check that ExternalString objects get aligned resources. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Check that ExternalString objects get aligned resources. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15894

Patch Set 1 #

Patch Set 2 : Added missing checks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/api.cc View 1 5 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 5 months ago (2013-07-25 14:24:07 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 5 months ago (2013-07-26 08:56:00 UTC) #2
Michael Starzinger
7 years, 5 months ago (2013-07-26 09:02:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698