third_party/WebKit/Source/platform/v8_inspector/V8Console.h - Issue 2030453002: [DevTools] Support CommandLineAPI in workers and Node.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.h

Issue 2030453002: [DevTools] Support CommandLineAPI in workers and Node.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h

index 1080baa60a7c31b206c1d627f8d6c22c9d9d78e5..91f0e5b97cef50b3ca4c3752af5b2521aba8d3e2 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h

@@ -16,7 +16,11 @@ class InspectedContext;

class V8Console {

public:

static v8::Local<v8::Object> createConsole(InspectedContext*, bool hasMemoryAttribute);

static v8::Local<v8::Object> createCommandLineAPI(InspectedContext*);

+ static v8::Local<v8::Object> installCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>, v8::Local<v8::Object> commandLineAPI);

+ static void clearCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>, v8::Local<v8::Object> installedMethods);

dgozman 2016/06/01 01:25:40 - let's name second parameter "global"; - let's us

kozy 2016/06/01 18:49:22 Done.

static void clearInspectedContextIfNeeded(v8::Local<v8::Context>, v8::Local<v8::Object> console);

private: