Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 2030453002: [DevTools] Support CommandLineAPI in workers and Node.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index c5d64c31eced0d48a56fcbc4d2ec4f7634ec4a7d..1de42b5dbe05252a1a8eacf5bbf03ba6b9cb6ec5 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -136,17 +136,6 @@ void ThreadDebugger::createFunctionProperty(v8::Local<v8::Context> context, v8::
return;
}
-bool ThreadDebugger::isCommandLineAPIMethod(const String& name)
-{
- DEFINE_STATIC_LOCAL(HashSet<String>, methods, ());
- if (methods.size() == 0) {
- const char* members[] = { "monitorEvents", "unmonitorEvents", "getEventListeners" };
- for (size_t i = 0; i < WTF_ARRAY_LENGTH(members); ++i)
- methods.add(members[i]);
- }
- return methods.find(name) != methods.end() || V8Debugger::isCommandLineAPIMethod(name);
-}
-
void ThreadDebugger::installAdditionalCommandLineAPI(v8::Local<v8::Context> context, v8::Local<v8::Object> object)
{
createFunctionProperty(context, object, "monitorEvents", ThreadDebugger::monitorEventsCallback, "function monitorEvents(object, [types]) { [Command Line API] }");

Powered by Google App Engine
This is Rietveld 408576698