Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 203042: windows.create({url:}) now supports relative paths. tabs.update()/tabs.move() now return Tab. (Closed)

Created:
11 years, 3 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Extension apis: windows.create({url:}) now supports relative paths. tabs.update() & tabs.move() now return full Tab object. BUG=17665 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26052

Patch Set 1 #

Patch Set 2 : added unit tests #

Patch Set 3 : forgot page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -19 lines) Patch
M chrome/browser/extensions/extension_tabs_module.cc View 6 chunks +24 lines, -7 lines 0 comments Download
M chrome/common/common_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 2 chunks +24 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/relative.html View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/test.js View 1 6 chunks +58 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
11 years, 3 months ago (2009-09-11 22:53:33 UTC) #1
lgtm!

Powered by Google App Engine
This is Rietveld 408576698