Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2030413002: Make click targets inside links work. (Closed)

Created:
4 years, 6 months ago by nektarios
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make click targets inside links work. There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility. For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic. BUG=615904 TBR=dmazzoni@chromium.org Committed: https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5 Cr-Commit-Position: refs/heads/master@{#397760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/accessibility/image-inside-link.html View 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nektarios
4 years, 6 months ago (2016-06-03 16:15:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030413002/1
4 years, 6 months ago (2016-06-03 16:16:57 UTC) #3
dmazzoni
lgtm
4 years, 6 months ago (2016-06-03 16:36:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:22:02 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5 Cr-Commit-Position: refs/heads/master@{#397760}
4 years, 6 months ago (2016-06-03 18:24:18 UTC) #7
jbroman
4 years, 6 months ago (2016-06-03 19:54:46 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2036943003/ by jbroman@chromium.org.

The reason for reverting is: Failing on Mac 10.11 (dbg):
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...

Error message is:

Harness Error. harness_status.status = 2 , harness_status.message = null

Sorry to revert this again. :(.

Powered by Google App Engine
This is Rietveld 408576698