Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html

Issue 2030383002: Convert track-webvtt-tc[027-029] tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html
index b023a751eca7125091b8adf3588b974998ccabd9..6c21b6b3334f9b66ba8390b47451d0dec02387b9 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html
@@ -1,28 +1,11 @@
<!DOCTYPE html>
-<html>
- <head>
- <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-
- <script src=../media-file.js></script>
- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
- <script src=../video-test.js></script>
- <script>
-
- function trackLoaded()
- {
- findMediaElement();
- testExpected("video.textTracks[0].cues.length", "0");
-
- endTest();
- }
-
- </script>
- </head>
- <body>
- <p>Tests that empty cues are discarded.</p>
- <video>
- <track src="captions-webvtt/tc027-empty-cue.vtt" onload="trackLoaded()" default>
- </video>
- </body>
-</html>
+<title>Tests that unsupported markup is properly ignored.</title>
+<script src="track-helpers.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script>
+// TODO(srirama.m): Correct the title and vtt file description.
+check_cues_from_track("captions-webvtt/tc027-empty-cue.vtt", function(track) {
+ assert_equals(track.cues.length, 3);
+});
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698