third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue-expected.txt - Issue 2030383002: Convert track-webvtt-tc[027-029] tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue-expected.txt

Issue 2030383002: Convert track-webvtt-tc[027-029] tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc027-empty-cue.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc028-unsupported-markup.html » ('j') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc028-unsupported-markup.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Tests that empty cues are discarded.	1 This is a testharness.js-based test.

	2 FAIL Check cues from captions-webvtt/tc027-empty-cue.vtt assert_equals: expected 0 but got 3
	Srirama 2016/06/03 14:09:29 There are few more tests with similar reason for f There are few more tests with similar reason for failure. Digged a bit into it thinking that i will fix it, but ended up outside blink here (https://cs.chromium.org/chromium/src/third_party/libwebm/source/webvtt/webvtt...). fs 2016/06/03 14:37:16 The correct parser would be the one at core/html/t Show quoted text On 2016/06/03 at 14:09:29, Srirama wrote: > There are few more tests with similar reason for failure. Digged a bit into it thinking that i will fix it, but ended up outside blink here (https://cs.chromium.org/chromium/src/third_party/libwebm/source/webvtt/webvtt...). The correct parser would be the one at core/html/track/vtt/VTTParser.cpp - this test predates a change to the spec though, so you can just update the test to expect 3 cues. (Looks like it was I that added the failing expectations... 164c59b7e86914c9a0eef9756ef6e8267bf13756) Srirama 2016/06/03 17:54:23 Done. Show quoted text On 2016/06/03 14:37:16, fs wrote: > On 2016/06/03 at 14:09:29, Srirama wrote: > > There are few more tests with similar reason for failure. Digged a bit into it > thinking that i will fix it, but ended up outside blink here > (https://cs.chromium.org/chromium/src/third_party/libwebm/source/webvtt/webvtt...). > > The correct parser would be the one at core/html/track/vtt/VTTParser.cpp - this > test predates a change to the spec though, so you can just update the test to > expect 3 cues. (Looks like it was I that added the failing expectations... > 164c59b7e86914c9a0eef9756ef6e8267bf13756) Done.
	3 Harness: the test ran to completion.

2	4

3 EXPECTED (video.textTracks[0].cues.length == '0'), OBSERVED '3' FAIL

4 END OF TEST

5

OLD	NEW