Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2030353002: UploadDataStream now returns errors on failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed issues and combined with HttpStreamParser cl due to dependencies Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index f1a3a2d733107727ba4edef0d645204e14334c2a..89c6864c9a4046c01dd60f8599328d422841c5e8 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -9684,18 +9684,12 @@ TEST_P(HttpNetworkTransactionTest, UploadFileSmallerThanLength) {
EXPECT_EQ(ERR_IO_PENDING, rv);
rv = callback.WaitForResult();
- EXPECT_EQ(OK, rv);
+ EXPECT_EQ(ERR_UPLOAD_FILE_CHANGED, rv);
const HttpResponseInfo* response = trans->GetResponseInfo();
ASSERT_TRUE(response);
- EXPECT_TRUE(response->headers);
- EXPECT_EQ("HTTP/1.0 200 OK", response->headers->GetStatusLine());
-
- std::string response_data;
- rv = ReadTransaction(trans.get(), &response_data);
- EXPECT_EQ(OK, rv);
- EXPECT_EQ("hello world", response_data);
+ EXPECT_FALSE(response->headers);
base::DeleteFile(temp_file_path, false);
}

Powered by Google App Engine
This is Rietveld 408576698