net/base/upload_data_stream.h - Issue 2030353002: UploadDataStream now returns errors on failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/upload_data_stream.h

Issue 2030353002: UploadDataStream now returns errors on failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed issues and combined with HttpStreamParser cl due to dependencies Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/upload_data_stream.h

diff --git a/net/base/upload_data_stream.h b/net/base/upload_data_stream.h

index fbfb32fee2680576de7b79209f8d595a305f4d1d..b3f360ef67f16bc83b2d1ad42185483d2d5bea41 100644

--- a/net/base/upload_data_stream.h

+++ b/net/base/upload_data_stream.h

@@ -56,9 +56,6 @@ class NET_EXPORT UploadDataStream {

// upload data is smaller than size()), zeros are padded to ensure that

// size() bytes can be read, which can happen for TYPE_FILE payloads.

- // Reads are currently not allowed to fail - they must either return

- // a value >= 0 or ERR_IO_PENDING, and call OnReadCompleted with a

- // value >= 0.

// TODO(mmenke): Investigate letting reads fail.

int Read(IOBuffer* buf, int buf_len, const CompletionCallback& callback);