net/base/elements_upload_data_stream.h - Issue 2030353002: UploadDataStream now returns errors on failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/elements_upload_data_stream.h

Issue 2030353002: UploadDataStream now returns errors on failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed issues and combined with HttpStreamParser cl due to dependencies Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/elements_upload_data_stream.h

diff --git a/net/base/elements_upload_data_stream.h b/net/base/elements_upload_data_stream.h

index 1d4934e14d12eb28baea5cd8a65c1fe6e00b0a69..296cfbb80520e90aa5d8da71e32a2ebfabe954d1 100644

--- a/net/base/elements_upload_data_stream.h

+++ b/net/base/elements_upload_data_stream.h

@@ -77,8 +77,8 @@ class NET_EXPORT ElementsUploadDataStream : public UploadDataStream {

// |upload_data_|.

size_t element_index_;

- // True if an error occcured during read operation.

- bool read_failed_;

+ // Set to actual error if read fails, otherwise set to net::OK.

+ int read_error_;

base::WeakPtrFactory<ElementsUploadDataStream> weak_ptr_factory_;