UploadDataStream now returns errors on failures

net/http/http_network_transaction_unittest.cc

Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 342e170cab3d2159015a9e3fb0e5a601999e0e5d..a82698f7e2d80e853bcfda9c0cae08074b3d771a 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -9684,18 +9684,17 @@ TEST_P(HttpNetworkTransactionTest, UploadFileSmallerThanLength) {
   EXPECT_EQ(ERR_IO_PENDING, rv);
 
   rv = callback.WaitForResult();
-  EXPECT_EQ(OK, rv);
+  EXPECT_EQ(ERR_UPLOAD_FILE_CHANGED, rv);
 
   const HttpResponseInfo* response = trans->GetResponseInfo();
   ASSERT_TRUE(response);
 
-  EXPECT_TRUE(response->headers);
-  EXPECT_EQ("HTTP/1.0 200 OK", response->headers->GetStatusLine());
+  EXPECT_FALSE(response->headers);

[mmenke, 2016/06/21 21:13:14]

Should remove code below this line (Code shouldn't be calling ReadTransaction
after a failure.  The fact that it works isn't great, but is probably true for
other errors, too)

[maksims (do not use this acc), 2016/06/22 15:10:32]

Done.

 
   std::string response_data;
   rv = ReadTransaction(trans.get(), &response_data);
   EXPECT_EQ(OK, rv);
-  EXPECT_EQ("hello world", response_data);
+  EXPECT_EQ("HTTP/1.0 200 OK\r\n\r\nhello world", response_data);
 
   base::DeleteFile(temp_file_path, false);
 }