Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: google_apis/drive/drive_api_parser.cc

Issue 203033002: Fix "unreachable code" warnings (MSVC warning 4702) in google_apis/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | google_apis/gaia/gaia_auth_fetcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_apis/drive/drive_api_parser.h" 5 #include "google_apis/drive/drive_api_parser.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 const base::Value& value) { 695 const base::Value& value) {
696 scoped_ptr<ImageMediaMetadata> resource(new ImageMediaMetadata()); 696 scoped_ptr<ImageMediaMetadata> resource(new ImageMediaMetadata());
697 if (!resource->Parse(value)) { 697 if (!resource->Parse(value)) {
698 LOG(ERROR) << "Unable to create: Invalid ImageMediaMetadata JSON!"; 698 LOG(ERROR) << "Unable to create: Invalid ImageMediaMetadata JSON!";
699 return scoped_ptr<ImageMediaMetadata>(); 699 return scoped_ptr<ImageMediaMetadata>();
700 } 700 }
701 return resource.Pass(); 701 return resource.Pass();
702 } 702 }
703 703
704 bool ImageMediaMetadata::Parse(const base::Value& value) { 704 bool ImageMediaMetadata::Parse(const base::Value& value) {
705 return true;
706 base::JSONValueConverter<ImageMediaMetadata> converter; 705 base::JSONValueConverter<ImageMediaMetadata> converter;
707 if (!converter.Convert(value, this)) { 706 if (!converter.Convert(value, this)) {
708 LOG(ERROR) << "Unable to parse: Invalid ImageMediaMetadata."; 707 LOG(ERROR) << "Unable to parse: Invalid ImageMediaMetadata.";
709 return false; 708 return false;
710 } 709 }
711 return true; 710 return true;
712 } 711 }
713 712
714 } // namespace google_apis 713 } // namespace google_apis
OLDNEW
« no previous file with comments | « no previous file | google_apis/gaia/gaia_auth_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698