Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 203033002: Fix "unreachable code" warnings (MSVC warning 4702) in google_apis/. (Closed)

Created:
6 years, 9 months ago by Peter Kasting
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix "unreachable code" warnings (MSVC warning 4702) in google_apis/. BUG=346399 TEST=none R=mtomasz@chromium.org, rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -129 lines) Patch
M google_apis/drive/drive_api_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +26 lines, -92 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 3 chunks +4 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Kasting
You'll notice an entire OAuth-related function and some unittests that called it are missing. After ...
6 years, 9 months ago (2014-03-18 03:20:50 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm For change in gaia_auth_fetcher, cool. For change in drive_api_parser, strange. The only place in ...
6 years, 9 months ago (2014-03-18 12:30:54 UTC) #2
mtomasz
On 2014/03/18 12:30:54, Roger Tawa wrote: > lgtm > > For change in gaia_auth_fetcher, cool. ...
6 years, 9 months ago (2014-03-18 13:32:25 UTC) #3
mtomasz
On 2014/03/18 13:32:25, mtomasz OOO until 21.03 wrote: > On 2014/03/18 12:30:54, Roger Tawa wrote: ...
6 years, 9 months ago (2014-03-18 13:36:19 UTC) #4
Peter Kasting
On 2014/03/18 12:30:54, Roger Tawa wrote: > If you choose to keep Parse(), please add ...
6 years, 9 months ago (2014-03-18 20:45:41 UTC) #5
Peter Kasting
6 years, 9 months ago (2014-03-18 20:47:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r257739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698