Print MachineTypes when using --trace-turbo-graph.

Print MachineTypes when using --trace-turbo-graph.

Previously, ZoneVector<MachineType>* printed just as a pointer; now we
print each MachineType in it, separated by commas.

BUG=

Committed: https://crrev.com/0d3413f87417c99182dbb39c85cf4541b0840112
Cr-Commit-Position: refs/heads/master@{#36736}

[bgeron, 2016-06-03 09:52:50]

bgeron@google.com changed reviewers:
+ jarin@chromium.org

[bgeron, 2016-06-03 11:29:25]

PTAL.

[Jarin, 2016-06-03 11:36:13]

lgtm with nits.

For turbofan-only CLs, we prefix the issue title with [turbofan].

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operato...
File src/compiler/common-operator.cc (right):

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operato...
src/compiler/common-operator.cc:173: for (const MachineType& elem : *zv) {
MachineType is small, "for (MachineType elem : ..." should be just fine.

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operato...
src/compiler/common-operator.h:139: std::ostream& operator<<(std::ostream& os,
const ZoneVector<MachineType>* zv);
zv -> types. We normally try not to use cryptic abbreviations ('os' is an
exception).

[bgeron, 2016-06-06 09:18:51]

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operato...
File src/compiler/common-operator.cc (right):

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operato...
src/compiler/common-operator.cc:173: for (const MachineType& elem : *zv) {
On 2016/06/03 11:36:13, Jarin wrote:
> MachineType is small, "for (MachineType elem : ..." should be just fine.

Done.

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):

https://codereview.chromium.org/2030323002/diff/1/src/compiler/common-operato...
src/compiler/common-operator.h:139: std::ostream& operator<<(std::ostream& os,
const ZoneVector<MachineType>* zv);
On 2016/06/03 11:36:13, Jarin wrote:
> zv -> types. We normally try not to use cryptic abbreviations ('os' is an
> exception).

Done.

[bgeron, 2016-06-06 09:21:20]

The CQ bit was checked by bgeron@google.com

[bgeron, 2016-06-06 09:21:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2030323002/#ps20001
(title: "Polish")

[commit-bot: I haz the power, 2016-06-06 09:21:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2030323002/20001

[commit-bot: I haz the power, 2016-06-06 09:44:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 09:47:19]

Description was changed from

==========
Print MachineTypes when using --trace-turbo-graph.

Previously, ZoneVector<MachineType>* printed just as a pointer; now we
print each MachineType in it, separated by commas.

BUG=
==========

to

==========
Print MachineTypes when using --trace-turbo-graph.

Previously, ZoneVector<MachineType>* printed just as a pointer; now we
print each MachineType in it, separated by commas.

BUG=

Committed: https://crrev.com/0d3413f87417c99182dbb39c85cf4541b0840112
Cr-Commit-Position: refs/heads/master@{#36736}
==========

[commit-bot: I haz the power, 2016-06-06 09:47:20]

Patchset 2 (id:??) landed as
https://crrev.com/0d3413f87417c99182dbb39c85cf4541b0840112
Cr-Commit-Position: refs/heads/master@{#36736}