Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issue 2030303002: X87: IC: Eliminate initialization_state as a factor in IC installation. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: IC: Eliminate initialization_state as a factor in IC installation. port 56d90782a5a97e1854e9564056f45b6374664d75 (r36597) original commit message: In Crankshaft, we would install special ICs that didn't need a vector and slot in the MEGAMORPHIC case. This optimization limits our hand against future improvements. BUG= Committed: https://crrev.com/82bce6a9fcdbc78da233ad958e0a996032721198 Cr-Commit-Position: refs/heads/master@{#36700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -48 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 5 chunks +14 lines, -24 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 5 chunks +7 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-03 08:37:36 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-03 08:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030303002/1
4 years, 6 months ago (2016-06-03 08:55:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 09:23:23 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 09:25:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82bce6a9fcdbc78da233ad958e0a996032721198
Cr-Commit-Position: refs/heads/master@{#36700}

Powered by Google App Engine
This is Rietveld 408576698