Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2030263002: Remove the last vestiges of RC4. (Closed)

Created:
4 years, 6 months ago by davidben
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the last vestiges of RC4. We've branched for 53 now, so the admin policy for enabling RC4 has expired. Remove it completely. Farewell, RC4. There was a time when you saved us from the beast and rabid poodles. By luck, you didn't have triskaidekaphobia, unlike our other friends who chained blocks together. (Boy are they annoying. It'd be wonderful if we could ditch them someday.) But you always had your biases, which made it hard to trust you with secrets. Now we have new friends who do the cha-cha twenty times a day and learned counting from some French mathematician. We just don't have room for you anymore. BUG=375342 Committed: https://crrev.com/6a260681b771e1042386d09d0fc4b31148030640 Cr-Commit-Position: refs/heads/master@{#398044}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : also the error string #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -59 lines) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M components/error_page_strings.grdp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/ssl_config/ssl_config_prefs.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/ssl_config/ssl_config_prefs.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref.cc View 1 4 chunks +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M net/ssl/ssl_config.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/ssl/ssl_config.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
davidben
4 years, 6 months ago (2016-06-02 22:57:37 UTC) #7
Thiemo Nagel
chrome/browser/policy LGTM
4 years, 6 months ago (2016-06-03 11:46:49 UTC) #8
davidben
Also modified components/error_page_strings.grdp. It will have been long enough that we probably shouldn't keep calling ...
4 years, 6 months ago (2016-06-03 17:40:11 UTC) #10
svaldez
lgtm
4 years, 6 months ago (2016-06-03 17:55:15 UTC) #11
davidben
tnagel: I missed clearing out the policy_test_cases.json entry. Still good?
4 years, 6 months ago (2016-06-03 19:31:54 UTC) #12
edwardjung
String update LGTM
4 years, 6 months ago (2016-06-06 11:15:45 UTC) #13
Thiemo Nagel
On 2016/06/03 19:31:54, davidben (OOO until 5-31) wrote: > tnagel: I missed clearing out the ...
4 years, 6 months ago (2016-06-06 11:36:45 UTC) #14
mmenke
On 2016/06/06 11:36:45, Thiemo Nagel wrote: > On 2016/06/03 19:31:54, davidben (OOO until 5-31) wrote: ...
4 years, 6 months ago (2016-06-06 14:56:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030263002/60001
4 years, 6 months ago (2016-06-06 15:15:16 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-06 16:24:57 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 16:26:29 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6a260681b771e1042386d09d0fc4b31148030640
Cr-Commit-Position: refs/heads/master@{#398044}

Powered by Google App Engine
This is Rietveld 408576698