Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: third_party/WebKit/Source/core/events/UIEvent.h

Issue 2030243004: Set Event.composed flag correctly for some of UA UIEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/UIEvent.h
diff --git a/third_party/WebKit/Source/core/events/UIEvent.h b/third_party/WebKit/Source/core/events/UIEvent.h
index b4d91ac25102369932b664cd2120c4ac45101b0d..a9cb2610a7dcbe9edbcaf6ac1c0676d07f0f5c00 100644
--- a/third_party/WebKit/Source/core/events/UIEvent.h
+++ b/third_party/WebKit/Source/core/events/UIEvent.h
@@ -45,7 +45,7 @@ public:
}
static UIEvent* create(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view, int detail)
{
- return new UIEvent(type, canBubble, cancelable, view, detail);
+ return new UIEvent(type, canBubble, cancelable, ComposedMode::Scoped, view, detail);
}
static UIEvent* create(const AtomicString& type, const UIEventInit& initializer)
{
@@ -70,8 +70,8 @@ public:
protected:
UIEvent();
// TODO(crbug.com/563542): Remove of this ctor in favor of making platformTimeStamp (and perhaps sourceCapabilities) required in all constructions sites
- UIEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView*, int detail, InputDeviceCapabilities* sourceCapabilities = nullptr);
- UIEvent(const AtomicString& type, bool canBubble, bool cancelable, double platformTimeStamp, AbstractView*, int detail, InputDeviceCapabilities* sourceCapabilities);
+ UIEvent(const AtomicString& type, bool canBubble, bool cancelable, ComposedMode, AbstractView*, int detail, InputDeviceCapabilities* sourceCapabilities = nullptr);
+ UIEvent(const AtomicString& type, bool canBubble, bool cancelable, ComposedMode, double platformTimeStamp, AbstractView*, int detail, InputDeviceCapabilities* sourceCapabilities);
UIEvent(const AtomicString&, const UIEventInit&);
private:
« no previous file with comments | « third_party/WebKit/Source/core/events/TextEvent.cpp ('k') | third_party/WebKit/Source/core/events/UIEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698