tools/perf/benchmarks/page_cycler_v2.py - Issue 2030243003: Disable page_cycler_v2.typical_25 on Android One and Nexus 5X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2030243003: Disable page_cycler_v2.typical_25 on Android One and Nexus 5X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/page_cycler_v2.py

diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py

index 3fd81079ed452bb171d3266f256abe908ef47923..04cf74b7d36ce70e328323384232ba44517fea5a 100644

--- a/tools/perf/benchmarks/page_cycler_v2.py

+++ b/tools/perf/benchmarks/page_cycler_v2.py

@@ -43,8 +43,10 @@ class PageCyclerV2Typical25(_PageCyclerV2):

@classmethod

def ShouldDisable(cls, possible_browser): # crbug.com/615178

- return (possible_browser.browser_type == 'reference' and

- possible_browser.platform.GetOSName() == 'android')

+ return ((possible_browser.browser_type == 'reference' and

+ possible_browser.platform.GetOSName() == 'android') or

+ cls.IsSvelte(possible_browser) or # crbug.com/616781

+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')

def CreateStorySet(self, options):

return page_sets.Typical25PageSet(run_no_page_interactions=True,

« no previous file with comments | « no previous file | no next file » | no next file with comments »