Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2030233003: [Mac][Material Design] Fix MD bookmarks button focus ring regression. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix MD bookmarks button focus ring regression. After the Material Design changes to the bookmarks bar the focus rings no longer align with the button images. R=avi@chromium.org BUG=613124 Committed: https://crrev.com/b8e8a8f7a7fc3f66e0bc149602d8abac251b0304 Cr-Commit-Position: refs/heads/master@{#397598}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
shrike
PTAL
4 years, 6 months ago (2016-06-02 23:23:07 UTC) #1
Avi (use Gerrit)
lgtm with nit https://codereview.chromium.org/2030233003/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right): https://codereview.chromium.org/2030233003/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm#newcode375 chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:375: inView:(NSView *)controlView { no space left ...
4 years, 6 months ago (2016-06-02 23:26:16 UTC) #2
shrike
https://codereview.chromium.org/2030233003/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm (right): https://codereview.chromium.org/2030233003/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm#newcode375 chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm:375: inView:(NSView *)controlView { On 2016/06/02 23:26:16, Avi wrote: > ...
4 years, 6 months ago (2016-06-02 23:59:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030233003/20001
4 years, 6 months ago (2016-06-03 00:03:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 02:44:44 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:47:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8e8a8f7a7fc3f66e0bc149602d8abac251b0304
Cr-Commit-Position: refs/heads/master@{#397598}

Powered by Google App Engine
This is Rietveld 408576698