net: migrate CreateMonsterFromStoreForGC() to CanonicalCookies::Create method - WIP

net/cookies/cookie_monster_store_test.cc

Index: net/cookies/cookie_monster_store_test.cc
diff --git a/net/cookies/cookie_monster_store_test.cc b/net/cookies/cookie_monster_store_test.cc
index 9d8259000293fb16ed003103a038e5664d56bcd2..01605f258f478b02c13f201aef3d9f1f135d9eb5 100644
--- a/net/cookies/cookie_monster_store_test.cc
+++ b/net/cookies/cookie_monster_store_test.cc
@@ -247,16 +247,12 @@ std::unique_ptr<CookieMonster> CreateMonsterFromStoreForGC(
     base::Time creation_time =
         past_creation + base::TimeDelta::FromMicroseconds(i);
     base::Time expiration_time = current + base::TimeDelta::FromDays(30);
-    base::Time last_access_time =
-        ((i - base) < num_old_cookies)
-            ? current - base::TimeDelta::FromDays(days_old)
-            : current;
-
-    CanonicalCookie cc(GURL(), "a", "1", base::StringPrintf("h%05d.izzle", i),
-                       "/path", creation_time, expiration_time,
-                       last_access_time, secure, false,
-                       CookieSameSite::DEFAULT_MODE, COOKIE_PRIORITY_DEFAULT);
-    store->AddCookie(cc);
+
+    std::unique_ptr<CanonicalCookie> cc(CanonicalCookie::Create(
+        GURL(base::StringPrintf("http://h%05d.izzle/", i)), "a", "1",
+        std::string(), "/path", creation_time, expiration_time, secure, false,
+        CookieSameSite::DEFAULT_MODE, false, COOKIE_PRIORITY_DEFAULT));

[mmenke, 2016/06/03 12:00:06]

Think you still need to set the last access date with cc->SetLastAccessDate.

[tfarina, 2016/06/03 16:30:13]

Awesome. Thanks Matt. This fixed it.

Done.

+    store->AddCookie(*cc);
   }
 
   return base::WrapUnique(new CookieMonster(store.get(), nullptr));