net: migrate CreateMonsterFromStoreForGC() to CanonicalCookies::Create method - WIP

net/cookies/cookie_monster_store_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cookies/cookie_monster_store_test.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 229 matching lines @@
       num_old_cookies = num_old_secure_cookies;
       secure = true;
     } else {
       base = num_secure_cookies;
       num_old_cookies = num_old_non_secure_cookies;
       secure = false;
     }
     base::Time creation_time =
         past_creation + base::TimeDelta::FromMicroseconds(i);
     base::Time expiration_time = current + base::TimeDelta::FromDays(30);
-    base::Time last_access_time =
-        ((i - base) < num_old_cookies)
-            ? current - base::TimeDelta::FromDays(days_old)
-            : current;
 
-    CanonicalCookie cc(GURL(), "a", "1", base::StringPrintf("h%05d.izzle", i),
-                       "/path", creation_time, expiration_time,
-                       last_access_time, secure, false,
-                       CookieSameSite::DEFAULT_MODE, COOKIE_PRIORITY_DEFAULT);
-    store->AddCookie(cc);
+    std::unique_ptr<CanonicalCookie> cc(CanonicalCookie::Create(
+        GURL(), "a", "1", base::StringPrintf("h%05d.izzle", i), "/path",
+        creation_time, expiration_time, secure, false,
+        CookieSameSite::DEFAULT_MODE, false, COOKIE_PRIORITY_DEFAULT));
+    store->AddCookie(*cc.release());

[tfarina, 2016/06/02 21:38:48]

I'm really missing something here. The test fails with release(). I have also
tried with just *cc, but this also fails.

Do you know the way to get this to work?

[mmenke, 2016/06/02 21:56:50]

You need to make GURL be a valid URL(Something like
GURL(base::StringPrintf("http://h%05d.izzle/", i))), and not set domain (Since
it's not a domain with a leading ".").

And you shouldn't be using release.

CanonicalCookie::Create and "new CanonicalCookie" treat GURL and domain fairly
differently, and that's the main reason to get rid of them - they're very
confusing (Though I didn't realize quite how confusing until you took this on).

[tfarina, 2016/06/03 11:54:52]

Done. Thank you.

   }
 
   return base::WrapUnique(new CookieMonster(store.get(), nullptr));
 }
 
 MockSimplePersistentCookieStore::~MockSimplePersistentCookieStore() {
 }
 
 }  // namespace net