Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 203023: add mole collapse/expand events. convert mappy to use this. (Closed)

Created:
11 years, 3 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

add mole collapse/expand events. convert mappy to use this. BUG=15494 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25976

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : add missing file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -3 lines) Patch
M chrome/browser/extensions/extension_shelf_model.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_toolstrip_api.h View 2 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_toolstrip_api.cc View 3 chunks +49 lines, -0 lines 1 comment Download
A chrome/browser/extensions/extension_toolstrip_apitest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 3 chunks +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/toolstrip/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/toolstrip/test.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/samples/mappy/mappy_toolstrip.html View 3 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik does not do reviews
11 years, 3 months ago (2009-09-10 22:54:01 UTC) #1
Matt Perry
LGTM http://codereview.chromium.org/203023/diff/4001/5002 File chrome/browser/extensions/extension_toolstrip_api.cc (right): http://codereview.chromium.org/203023/diff/4001/5002#newcode166 Line 166: if (!url.is_empty()) should we set the .url ...
11 years, 3 months ago (2009-09-10 23:02:50 UTC) #2
Erik does not do reviews
11 years, 3 months ago (2009-09-10 23:07:18 UTC) #3
On Thu, Sep 10, 2009 at 4:02 PM,  <mpcomplete@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/203023/diff/4001/5002
> File chrome/browser/extensions/extension_toolstrip_api.cc (right):
>
> http://codereview.chromium.org/203023/diff/4001/5002#newcode166
> Line 166: if (!url.is_empty())
> should we set the .url property to be "" rather than undefined in this
> case?

The style of our other "update-style" APIs is to leave properties out
if they haven't changed.

Erik

Powered by Google App Engine
This is Rietveld 408576698