Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2030223002: Introduce --vr-shell flag on Android (Closed)

Created:
4 years, 6 months ago by bshe
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce --vr-shell flag on Android BUG=617946 Committed: https://crrev.com/ccf69a1673986f7af139e2940a71418fe4e3d890 Cr-Commit-Position: refs/heads/master@{#399025}

Patch Set 1 #

Patch Set 2 : add missing flag to histogram #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
bshe
Hi guys. Do you mind take a look at this CL? Thanks +sievers for content/* ...
4 years, 6 months ago (2016-06-07 13:48:41 UTC) #4
Ilya Sherman
histograms.xml lgtm
4 years, 6 months ago (2016-06-07 19:26:53 UTC) #5
no sievers
why is it a content flag though? 'shell' sounds like something embedder specific which content ...
4 years, 6 months ago (2016-06-07 21:42:13 UTC) #6
bshe
On 2016/06/07 21:42:13, sievers wrote: > why is it a content flag though? 'shell' sounds ...
4 years, 6 months ago (2016-06-07 22:37:42 UTC) #7
no sievers
On 2016/06/07 22:37:42, bshe wrote: > On 2016/06/07 21:42:13, sievers wrote: > > why is ...
4 years, 6 months ago (2016-06-07 22:45:29 UTC) #8
bshe
On 2016/06/07 22:45:29, sievers wrote: > On 2016/06/07 22:37:42, bshe wrote: > > On 2016/06/07 ...
4 years, 6 months ago (2016-06-09 13:57:22 UTC) #11
no sievers
On 2016/06/09 13:57:22, bshe wrote: > On 2016/06/07 22:45:29, sievers wrote: > > On 2016/06/07 ...
4 years, 6 months ago (2016-06-09 17:59:14 UTC) #12
bshe
On 2016/06/09 17:59:14, sievers wrote: > On 2016/06/09 13:57:22, bshe wrote: > > On 2016/06/07 ...
4 years, 6 months ago (2016-06-09 18:11:57 UTC) #13
no sievers
lgtm
4 years, 6 months ago (2016-06-09 19:07:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030223002/80001
4 years, 6 months ago (2016-06-09 21:13:04 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 6 months ago (2016-06-09 21:36:05 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 21:36:25 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 21:38:33 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ccf69a1673986f7af139e2940a71418fe4e3d890
Cr-Commit-Position: refs/heads/master@{#399025}

Powered by Google App Engine
This is Rietveld 408576698