Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2030203002: MD Site Settings: Add icons for a few categories. (Closed)

Created:
4 years, 6 months ago by Finnur
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Site Settings: Add icons for a few categories. BUG=614277, 614277, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8e1b4e7ae7d21f64f85dad5d35235fd443277cae Cr-Commit-Position: refs/heads/master@{#397588}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/settings/icons.html View 1 5 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Finnur
4 years, 6 months ago (2016-06-02 20:02:35 UTC) #4
dschuyler
LGTM with a request to try timing them down. https://codereview.chromium.org/2030203002/diff/1/chrome/browser/resources/settings/icons.html File chrome/browser/resources/settings/icons.html (right): https://codereview.chromium.org/2030203002/diff/1/chrome/browser/resources/settings/icons.html#newcode46 chrome/browser/resources/settings/icons.html:46: ...
4 years, 6 months ago (2016-06-02 22:18:15 UTC) #5
Finnur
> Please try removing them to see if I'm correct. Correct, as always. :)
4 years, 6 months ago (2016-06-03 00:47:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030203002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030203002/2
4 years, 6 months ago (2016-06-03 00:48:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:2)
4 years, 6 months ago (2016-06-03 02:36:40 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:38:58 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e1b4e7ae7d21f64f85dad5d35235fd443277cae
Cr-Commit-Position: refs/heads/master@{#397588}

Powered by Google App Engine
This is Rietveld 408576698