Add 'total' field to 'PaymentDetails'.

Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568
Committed: https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9
Cr-Commit-Position: refs/heads/master@{#397867}

[please use gerrit instead, 2016-06-02 22:28:03]

Description was changed from

==========
Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes 'items'
field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * null, undefined, or empty 'items' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentde...
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff7...

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568
==========

to

==========
Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes 'items'
field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'items' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentde...
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff7...

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568
==========

[please use gerrit instead, 2016-06-02 22:30:35]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-06-02 22:31:30]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2016-06-02 22:37:09]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mek@chromium.org, tsepez@chromium.org

[please use gerrit instead, 2016-06-02 22:37:09]

dfalcantara@: ptal Java.

mek@: ptal WebKit.

tsepez@: ptal payment_request.mojom.

[Marijn Kruisselbrink, 2016-06-02 22:55:07]

lgtm

[Tom Sepez, 2016-06-02 23:45:00]

mojom lgtm

[gone, 2016-06-03 17:07:41]

Java lgtm.

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:56:
PaymentApp.InstrumentsCallback,
Don't indent like this in Java-land.

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:410:
* Updates the total and how its broken down.
it's

[please use gerrit instead, 2016-06-03 21:49:40]

Description was changed from

==========
Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes 'items'
field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'items' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentde...
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff7...

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568
==========

to

==========
Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentde...
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff7...

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568
==========

[please use gerrit instead, 2016-06-03 22:04:14]

Sending to cq.

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:56:
PaymentApp.InstrumentsCallback,
On 2016/06/03 17:07:41, dfalcantara wrote:
> Don't indent like this in Java-land.

Done.

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2030193002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:410:
* Updates the total and how its broken down.
On 2016/06/03 17:07:41, dfalcantara wrote:
> it's

Done.

[please use gerrit instead, 2016-06-03 23:29:15]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-03 23:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
mek@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2030193002/#ps60001
(title: "Rebase, address comments, and add more tests")

[commit-bot: I haz the power, 2016-06-03 23:29:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2030193002/60001

[commit-bot: I haz the power, 2016-06-04 00:51:30]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-06-04 00:54:18]

Description was changed from

==========
Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentde...
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff7...

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568
==========

to

==========
Add 'total' field to 'PaymentDetails'.

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentde...
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff7...

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568

Committed: https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9
Cr-Commit-Position: refs/heads/master@{#397867}
==========

[commit-bot: I haz the power, 2016-06-04 00:54:19]

Patchset 2 (id:??) landed as
https://crrev.com/11f37c673b5fdbf558b295eb2749df391852e5d9
Cr-Commit-Position: refs/heads/master@{#397867}