Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2030173002: Simplify StructTraits tests (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify StructTraits tests Using sync method calls simplifies unit tests. I've switched the exists tests over. BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/41884894e5ae747cab71385863dcb221d3ee2c45 Cr-Commit-Position: refs/heads/master@{#397554}

Patch Set 1 #

Patch Set 2 : Added comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -90 lines) Patch
M cc/ipc/struct_traits_unittest.cc View 6 chunks +37 lines, -60 lines 0 comments Download
M cc/ipc/traits_test_service.mojom View 1 1 chunk +12 lines, -1 line 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 5 chunks +19 lines, -29 lines 0 comments Download
M gpu/ipc/common/traits_test_service.mojom View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Fady Samuel
4 years, 6 months ago (2016-06-02 19:32:36 UTC) #4
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-02 20:12:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030173002/20001
4 years, 6 months ago (2016-06-02 20:47:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 00:16:28 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 00:18:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41884894e5ae747cab71385863dcb221d3ee2c45
Cr-Commit-Position: refs/heads/master@{#397554}

Powered by Google App Engine
This is Rietveld 408576698