Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2030123002: Fix argument parsing in android app launcher script (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
djsollen, liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix argument parsing in android app launcher script Makes the argument match the error message that gets printed (and users' expectations). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030123002 Committed: https://skia.googlesource.com/skia/+/0dd9f2cbc445c477a840743420a6b2867ebbe120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/bin/android_launch_app View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Brian Osman
4 years, 6 months ago (2016-06-02 18:18:14 UTC) #3
liyuqian
On 2016/06/02 18:18:14, Brian Osman wrote: LGTM. Derek is on vacation. I don't know the ...
4 years, 6 months ago (2016-06-02 18:25:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030123002/1
4 years, 6 months ago (2016-06-02 18:26:14 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 18:44:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0dd9f2cbc445c477a840743420a6b2867ebbe120

Powered by Google App Engine
This is Rietveld 408576698