Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 20301: Check for hung plugin windows before detaching them... (Closed)

Created:
11 years, 10 months ago by amit
Modified:
9 years ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Check for hung plugin windows before detaching them The process of detaching plugin windows from tab window involves windows messages across browser and plugin process. If the pungin process is hung this hangs the browser shutdown sequence. This workaround first checks if the plugin is responsive before detaching its window from the tab. If a plugin is hung, it's window would not be detached (and would be destroyed with the tab window). The side effect of not detaching is that some plugins expect their window to be valid until they get NPAPI shut down notifications and may crash if those notifications were sent after the window was destroyed. But since the plugin is hung anyway, we can go ahead not detaching the window. Plugin process will be cleaned up later. BUG=3613 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/tab_contents/web_contents_view_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
amit
11 years, 10 months ago (2009-02-12 16:26:07 UTC) #1
cpu_(ooo_6.6-7.5)
LGTM
11 years, 10 months ago (2009-02-12 19:14:26 UTC) #2
ananta
11 years, 10 months ago (2009-02-12 23:03:51 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698