Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2030063002: Fix bytecode operand type (Closed)

Created:
4 years, 6 months ago by miran.karic
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bytecode operand type A value in unittests/Bytecodes.DecodeBytecodeAndOperands was 16 bit instead of 8 bit. This was causing test to fail on big endian machines. BUG= Committed: https://crrev.com/16dda2152f4823e7557e76fe993199703d872227 Cr-Commit-Position: refs/heads/master@{#36698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/unittests/interpreter/bytecodes-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
miran.karic
4 years, 6 months ago (2016-06-02 15:32:46 UTC) #3
oth
Thanks Miran. LGTM.
4 years, 6 months ago (2016-06-02 15:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030063002/1
4 years, 6 months ago (2016-06-03 08:09:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 08:35:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16dda2152f4823e7557e76fe993199703d872227 Cr-Commit-Position: refs/heads/master@{#36698}
4 years, 6 months ago (2016-06-03 08:36:35 UTC) #10
Jakob Kummerow
DBC: CLs that only affect tests should make this obvious in their title, e.g. with ...
4 years, 6 months ago (2016-06-03 12:13:29 UTC) #12
miran.karic
4 years, 6 months ago (2016-06-03 12:36:31 UTC) #13
Message was sent while issue was closed.
On 2016/06/03 12:13:29, Jakob wrote:
> DBC: CLs that only affect tests should make this obvious in their title, e.g.
> with a [test] prefix, in order to make it easier to ignore them when scanning
> through regression ranges.

I will keep that in mind for the future, thank you.

Powered by Google App Engine
This is Rietveld 408576698