Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2030043004: Create a tab upon creation of a fake browser instance. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Create a tab upon creation of a fake browser instance. Fixes problems where unit tests did not have the same behavior as the desktop browser backend. BUG=chromium:352807 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/05cd4f2553bbacce40bb53b078e5c43d2b370a8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M telemetry/telemetry/testing/fakes/__init__.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
PTAL. This blocks the introduction of browser restarts in gpu_integration_test.py in the Chromium workspace. Thanks.
4 years, 6 months ago (2016-06-02 21:05:17 UTC) #2
nednguyen
lgtm
4 years, 6 months ago (2016-06-02 21:16:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030043004/1
4 years, 6 months ago (2016-06-02 21:16:45 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 21:48:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698