content/browser/renderer_host/render_widget_host_view_android.cc - Issue 2030033003: Replace cc::ViewportSelectionBound with gfx::SelectionBound

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2030033003: Replace cc::ViewportSelectionBound with gfx::SelectionBound (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android build compiles locally Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | ui/gfx/ipc/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 04f9f1207b0ea964b6a200a61f58745b40c8ff60..2a07e892a5575bbc3dc81a3966335d9da2536aa5 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -27,7 +27,6 @@

#include "cc/output/copy_output_request.h"

#include "cc/output/copy_output_result.h"

#include "cc/output/latency_info_swap_promise.h"

-#include "cc/output/viewport_selection_bound.h"

#include "cc/resources/single_release_callback.h"

#include "cc/surfaces/surface.h"

#include "cc/surfaces/surface_factory.h"

@@ -51,7 +50,6 @@

#include "content/browser/renderer_host/dip_util.h"

#include "content/browser/renderer_host/frame_metadata_util.h"

#include "content/browser/renderer_host/input/synthetic_gesture_target_android.h"

-#include "content/browser/renderer_host/input/ui_touch_selection_helper.h"

#include "content/browser/renderer_host/input/web_input_event_builders_android.h"

#include "content/browser/renderer_host/input/web_input_event_util.h"

#include "content/browser/renderer_host/render_process_host_impl.h"

@@ -1286,8 +1284,7 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(

selection_controller_->OnSelectionEmpty(

frame_metadata.selection.is_empty_text_form_control);

selection_controller_->OnSelectionBoundsChanged(

- ConvertSelectionBound(frame_metadata.selection.start),

- ConvertSelectionBound(frame_metadata.selection.end));

+ frame_metadata.selection.start, frame_metadata.selection.end);

// Set parameters for adaptive handle orientation.

gfx::SizeF viewport_size(frame_metadata.scrollable_viewport_size);