Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2030023002: Reland of Stopped WebVR from being partially enabled during testing. (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
Reviewers:
esprehn, bajones
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2030913002/ ) Reason for revert: This revert was speculative and the test proved to be too flaky for the revert results to be conclusive. Sorry for the noise, relanding. Original issue's description: > Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ ) > > Reason for revert: > Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots. > For more info see: > BUG=616730 > > Original issue's description: > > Stopped WebVR from being partially enabled during testing. > > > > Should prevent repeated instances of "blink::mojom::VRService not found" in test > > logs. > > > > BUG=614752 > > > > Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a > > Cr-Commit-Position: refs/heads/master@{#397335} > > TBR=esprehn@chromium.org,bajones@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=614752 > > Committed: https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617 > Cr-Commit-Position: refs/heads/master@{#397372} TBR=esprehn@chromium.org,bajones@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616730 Committed: https://crrev.com/afc1a78a173991463b44ea98822994f80075b1c5 Cr-Commit-Position: refs/heads/master@{#397373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/child/runtime_features.cc View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
vabr (Chromium)
Created Reland of Stopped WebVR from being partially enabled during testing.
4 years, 6 months ago (2016-06-02 11:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030023002/1
4 years, 6 months ago (2016-06-02 11:58:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 11:58:55 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 12:00:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afc1a78a173991463b44ea98822994f80075b1c5
Cr-Commit-Position: refs/heads/master@{#397373}

Powered by Google App Engine
This is Rietveld 408576698