chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc - Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 2030013003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

index 5f6b7221ada6e88feabe7cc8f9fa8c3c9d767ba0..ef9c1b27b854af04dd42ecdccb142f470f73a0b8 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

@@ -100,7 +100,7 @@ class WebRequestRulesRegistryTest : public testing::Test {

// https://www.example.com and cancels it

linked_ptr<api::events::Rule> CreateRule1() {

base::ListValue* scheme_http = new base::ListValue();

- scheme_http->Append(new base::StringValue("http"));

+ scheme_http->AppendString("http");

base::DictionaryValue* http_condition_dict = new base::DictionaryValue();

http_condition_dict->Set(keys2::kSchemesKey, scheme_http);

http_condition_dict->SetString(keys2::kHostSuffixKey, "example.com");

@@ -110,7 +110,7 @@ class WebRequestRulesRegistryTest : public testing::Test {

keys::kRequestMatcherType);

base::ListValue* scheme_https = new base::ListValue();

- scheme_http->Append(new base::StringValue("https"));

+ scheme_http->AppendString("https");

base::DictionaryValue* https_condition_dict = new base::DictionaryValue();

https_condition_dict->Set(keys2::kSchemesKey, scheme_https);

https_condition_dict->SetString(keys2::kHostSuffixKey, "example.com");