Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/test/chromedriver/window_commands.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/window_commands.h"
 
 #include <stddef.h>
 
 #include <list>
 #include <string>
@@ skipping 346 matching lines @@
     std::string id_string;
     int id_int;
     if (id->GetAsString(&id_string)) {
       xpath += base::StringPrintf(
           "[@name=\"%s\" or @id=\"%s\"]", id_string.c_str(), id_string.c_str());
     } else if (id->GetAsInteger(&id_int)) {
       xpath += base::StringPrintf("[%d]", id_int + 1);
     } else {
       return Status(kUnknownError, "invalid 'id'");
     }
-    args.Append(new base::StringValue(xpath));
+    args.AppendString(xpath);
   }
   std::string frame;
   Status status = web_view->GetFrameByFunction(
       session->GetCurrentFrameId(), script, args, &frame);
   if (status.IsError())
     return status;
 
   std::unique_ptr<base::Value> result;
   status = web_view->CallFunction(
       session->GetCurrentFrameId(), script, args, &result);
@@ skipping 365 matching lines @@
 Status ExecuteGetStorageItem(const char* storage,
                              Session* session,
                              WebView* web_view,
                              const base::DictionaryValue& params,
                              std::unique_ptr<base::Value>* value,
                              Timeout* timeout) {
   std::string key;
   if (!params.GetString("key", &key))
     return Status(kUnknownError, "'key' must be a string");
   base::ListValue args;
-  args.Append(new base::StringValue(key));
+  args.AppendString(key);
   return web_view->CallFunction(
       session->GetCurrentFrameId(),
       base::StringPrintf("function(key) { return %s[key]; }", storage),
       args,
       value);
 }
 
 Status ExecuteGetStorageKeys(const char* storage,
                              Session* session,
                              WebView* web_view,
@@ skipping 18 matching lines @@
                              const base::DictionaryValue& params,
                              std::unique_ptr<base::Value>* value,
                              Timeout* timeout) {
   std::string key;
   if (!params.GetString("key", &key))
     return Status(kUnknownError, "'key' must be a string");
   std::string storage_value;
   if (!params.GetString("value", &storage_value))
     return Status(kUnknownError, "'value' must be a string");
   base::ListValue args;
-  args.Append(new base::StringValue(key));
-  args.Append(new base::StringValue(storage_value));
+  args.AppendString(key);
+  args.AppendString(storage_value);
   return web_view->CallFunction(
       session->GetCurrentFrameId(),
       base::StringPrintf("function(key, value) { %s[key] = value; }", storage),
       args,
       value);
 }
 
 Status ExecuteRemoveStorageItem(const char* storage,
                                 Session* session,
                                 WebView* web_view,
                                 const base::DictionaryValue& params,
                                 std::unique_ptr<base::Value>* value,
                                 Timeout* timeout) {
   std::string key;
   if (!params.GetString("key", &key))
     return Status(kUnknownError, "'key' must be a string");
   base::ListValue args;
-  args.Append(new base::StringValue(key));
+  args.AppendString(key);
   return web_view->CallFunction(
       session->GetCurrentFrameId(),
       base::StringPrintf("function(key) { %s.removeItem(key) }", storage),
       args,
       value);
 }
 
 Status ExecuteClearStorage(const char* storage,
                            Session* session,
                            WebView* web_view,
@@ skipping 238 matching lines @@
   return status;
 }
 
 Status ExecuteTakeHeapSnapshot(Session* session,
                                WebView* web_view,
                                const base::DictionaryValue& params,
                                std::unique_ptr<base::Value>* value,
                                Timeout* timeout) {
   return web_view->TakeHeapSnapshot(value);
 }