Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome

chrome/common/extensions/permissions/permission_set_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 335 matching lines @@
 
   std::unique_ptr<const PermissionSet> set1;
   std::unique_ptr<const PermissionSet> set2;
   std::unique_ptr<const PermissionSet> union_set;
 
   const APIPermissionInfo* permission_info =
     PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
+    value->AppendString("tcp-connect:*.example.com:80");
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
 
   // Union with an empty set.
   apis1.insert(APIPermission::kTab);
   apis1.insert(APIPermission::kBackground);
   apis1.insert(permission->Clone());
   expected_apis.insert(APIPermission::kTab);
   expected_apis.insert(APIPermission::kBackground);
   expected_apis.insert(permission);
@@ skipping 22 matching lines @@
 
   // Now use a real second set.
   apis2.insert(APIPermission::kTab);
   apis2.insert(APIPermission::kProxy);
   apis2.insert(APIPermission::kClipboardWrite);
   apis2.insert(APIPermission::kPlugin);
 
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
-    value->Append(new base::StringValue("udp-send-to::8899"));
+    value->AppendString("tcp-connect:*.example.com:80");
+    value->AppendString("udp-send-to::8899");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   apis2.insert(permission);
 
   expected_apis.insert(APIPermission::kTab);
   expected_apis.insert(APIPermission::kProxy);
   expected_apis.insert(APIPermission::kClipboardWrite);
   expected_apis.insert(APIPermission::kPlugin);
 
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
-    value->Append(new base::StringValue("udp-send-to::8899"));
+    value->AppendString("tcp-connect:*.example.com:80");
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
+    value->AppendString("udp-send-to::8899");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   // Insert a new permission socket permisssion which will replace the old one.
   expected_apis.insert(permission);
 
   AddPattern(&explicit_hosts2, "http://*.example.com/*");
   AddPattern(&scriptable_hosts2, "http://*.google.com/*");
   AddPattern(&expected_explicit_hosts, "http://*.example.com/*");
   AddPattern(&expected_scriptable_hosts, "http://*.google.com/*");
 
@@ skipping 43 matching lines @@
 
   const APIPermissionInfo* permission_info =
     PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
 
   // Intersection with an empty set.
   apis1.insert(APIPermission::kTab);
   apis1.insert(APIPermission::kBackground);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
+    value->AppendString("tcp-connect:*.example.com:80");
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   apis1.insert(permission);
 
   AddPattern(&explicit_hosts1, "http://*.google.com/*");
   AddPattern(&scriptable_hosts1, "http://www.reddit.com/*");
 
   set1.reset(new PermissionSet(apis1, manifest_permissions, explicit_hosts1,
                                scriptable_hosts1));
   set2.reset(new PermissionSet(apis2, manifest_permissions, explicit_hosts2,
@@ skipping 14 matching lines @@
   EXPECT_EQ(expected_explicit_hosts, new_set->effective_hosts());
 
   // Now use a real second set.
   apis2.insert(APIPermission::kTab);
   apis2.insert(APIPermission::kProxy);
   apis2.insert(APIPermission::kClipboardWrite);
   apis2.insert(APIPermission::kPlugin);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
-    value->Append(new base::StringValue("udp-send-to::8899"));
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
+    value->AppendString("udp-send-to::8899");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   apis2.insert(permission);
 
   expected_apis.insert(APIPermission::kTab);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   expected_apis.insert(permission);
 
   AddPattern(&explicit_hosts2, "http://*.example.com/*");
   AddPattern(&explicit_hosts2, "http://*.google.com/*");
   AddPattern(&scriptable_hosts2, "http://*.google.com/*");
   AddPattern(&expected_explicit_hosts, "http://*.google.com/*");
 
   effective_hosts.ClearPatterns();
@@ skipping 42 matching lines @@
 
   const APIPermissionInfo* permission_info =
     PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
 
   // Difference with an empty set.
   apis1.insert(APIPermission::kTab);
   apis1.insert(APIPermission::kBackground);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
+    value->AppendString("tcp-connect:*.example.com:80");
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   apis1.insert(permission);
 
   AddPattern(&explicit_hosts1, "http://*.google.com/*");
   AddPattern(&scriptable_hosts1, "http://www.reddit.com/*");
 
   set1.reset(new PermissionSet(apis1, manifest_permissions, explicit_hosts1,
                                scriptable_hosts1));
   set2.reset(new PermissionSet(apis2, manifest_permissions, explicit_hosts2,
                                scriptable_hosts2));
   new_set = PermissionSet::CreateDifference(*set1, *set2);
   EXPECT_EQ(*set1, *new_set);
 
   // Now use a real second set.
   apis2.insert(APIPermission::kTab);
   apis2.insert(APIPermission::kProxy);
   apis2.insert(APIPermission::kClipboardWrite);
   apis2.insert(APIPermission::kPlugin);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
-    value->Append(new base::StringValue("udp-send-to::8899"));
+    value->AppendString("tcp-connect:*.example.com:80");
+    value->AppendString("udp-send-to::8899");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   apis2.insert(permission);
 
   expected_apis.insert(APIPermission::kBackground);
   permission = permission_info->CreateAPIPermission();
   {
     std::unique_ptr<base::ListValue> value(new base::ListValue());
-    value->Append(new base::StringValue("udp-bind::8080"));
-    value->Append(new base::StringValue("udp-send-to::8888"));
+    value->AppendString("udp-bind::8080");
+    value->AppendString("udp-send-to::8888");
     ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
   }
   expected_apis.insert(permission);
 
   AddPattern(&explicit_hosts2, "http://*.example.com/*");
   AddPattern(&explicit_hosts2, "http://*.google.com/*");
   AddPattern(&scriptable_hosts2, "http://*.google.com/*");
   AddPattern(&expected_scriptable_hosts, "http://www.reddit.com/*");
 
   effective_hosts.ClearPatterns();
@@ skipping 1125 matching lines @@
   scoped_refptr<Extension> extension_dwr(
       LoadManifest("permissions", "web_request_all_host_permissions.json"));
   const PermissionSet& permissions_dwr =
       extension_dwr->permissions_data()->active_permissions();
 
   EXPECT_FALSE(PermissionMessageProvider::Get()->IsPrivilegeIncrease(
       permissions, permissions_dwr, extension->GetType()));
 }
 
 }  // namespace extensions