Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2030003002: MIPS64: Add clang compile flags for MIPS64r6 (Closed)

Created:
4 years, 6 months ago by gordanac
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, gordanac
CC:
chromium-reviews, petar.jovanovic
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MIPS64EL: Add clang compile flags for MIPS64r6 Adding clang flags for mips64r6 Android in gn and gyp (plus correcting mips32r6 flags in gyp), though gyp is obsolete. BUG=compile error TEST=gn gen out-gn/mips64-android --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\" chrome_public_apk_use_chromium_linker=false is_clang=true" ninja -C out-gn/mips64-android chrome_public_apk Committed: https://crrev.com/77d1f92dcd46a91dcdde9622c6012f5da0a7d53d Cr-Commit-Position: refs/heads/master@{#397691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -12 lines) Patch
M build/common.gypi View 3 chunks +44 lines, -4 lines 0 comments Download
M build/config/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
gordanac
Please take a look.
4 years, 6 months ago (2016-06-02 09:04:49 UTC) #3
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-02 17:49:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030003002/1
4 years, 6 months ago (2016-06-03 08:19:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/232892)
4 years, 6 months ago (2016-06-03 11:37:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030003002/1
4 years, 6 months ago (2016-06-03 12:00:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 12:59:16 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 13:00:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77d1f92dcd46a91dcdde9622c6012f5da0a7d53d
Cr-Commit-Position: refs/heads/master@{#397691}

Powered by Google App Engine
This is Rietveld 408576698