Hide media sinks that don't have a name in the cast system tray.

Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later.

BUG=616683
Committed: https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e
Cr-Commit-Position: refs/heads/master@{#397481}

[jdufault, 2016-06-02 06:18:48]

Patchset #1 (id:1) has been deleted

[amp, 2016-06-02 16:49:24]

https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/c...
File chrome/browser/ui/ash/cast_config_delegate_media_router.cc (right):

https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/c...
chrome/browser/ui/ash/cast_config_delegate_media_router.cc:103: if
(sink.name().empty())
Until we can duplicate the logic in
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/media_router/med...
we should also filter out all sinks with a domain.

if (!sink.domain().empty())
  continue;

This should also cover the case where sinks are coming back with no name, as
those are specifically tied to having a domain.

[jdufault, 2016-06-02 17:34:12]

Description was changed from

==========
Don't show media sinks that don't have a name in the cast system tray.

BUG=616683
==========

to

==========
Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet
privacy requirements. The logic to decide if a sink with a domain should be
displayed will be added later.

BUG=616683
==========

[jdufault, 2016-06-02 17:35:14]

https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/c...
File chrome/browser/ui/ash/cast_config_delegate_media_router.cc (right):

https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/c...
chrome/browser/ui/ash/cast_config_delegate_media_router.cc:103: if
(sink.name().empty())
On 2016/06/02 16:49:24, amp wrote:
> Until we can duplicate the logic in
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/media_router/med...
> we should also filter out all sinks with a domain.
> 
> if (!sink.domain().empty())
>   continue;
> 
> This should also cover the case where sinks are coming back with no name, as
> those are specifically tied to having a domain.

Done.

[jdufault, 2016-06-02 17:35:47]

jdufault@chromium.org changed reviewers:
+ oshima@chromium.org

[jdufault, 2016-06-02 17:38:55]

Oshima, PTAL. This fixes b/29073993 and provides a temporary fix for b/28691645.
This will need to be merged back into m52 as it blocks the media router launch.

[oshima, 2016-06-02 18:13:30]

lgtm

[jdufault, 2016-06-02 18:13:48]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-06-02 18:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029963002/40001

[commit-bot: I haz the power, 2016-06-02 18:43:48]

Description was changed from

==========
Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet
privacy requirements. The logic to decide if a sink with a domain should be
displayed will be added later.

BUG=616683
==========

to

==========
Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet
privacy requirements. The logic to decide if a sink with a domain should be
displayed will be added later.

BUG=616683
==========

[commit-bot: I haz the power, 2016-06-02 18:43:49]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-02 18:45:10]

Description was changed from

==========
Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet
privacy requirements. The logic to decide if a sink with a domain should be
displayed will be added later.

BUG=616683
==========

to

==========
Hide media sinks that don't have a name in the cast system tray.

This also hides media sinks that have a domain, as a temporary fix to meet
privacy requirements. The logic to decide if a sink with a domain should be
displayed will be added later.

BUG=616683

Committed: https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e
Cr-Commit-Position: refs/heads/master@{#397481}
==========

[commit-bot: I haz the power, 2016-06-02 18:45:11]

Patchset 2 (id:??) landed as
https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e
Cr-Commit-Position: refs/heads/master@{#397481}