Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2029963002: Hide media sinks that don't have a name in the cast system tray. (Closed)

Created:
4 years, 6 months ago by jdufault
Modified:
4 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide media sinks that don't have a name in the cast system tray. This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later. BUG=616683 Committed: https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e Cr-Commit-Position: refs/heads/master@{#397481}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Also filter sinks with a domain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/ui/ash/cast_config_delegate_media_router.cc View 1 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
amp
https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/cast_config_delegate_media_router.cc File chrome/browser/ui/ash/cast_config_delegate_media_router.cc (right): https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/cast_config_delegate_media_router.cc#newcode103 chrome/browser/ui/ash/cast_config_delegate_media_router.cc:103: if (sink.name().empty()) Until we can duplicate the logic in ...
4 years, 6 months ago (2016-06-02 16:49:24 UTC) #2
jdufault
https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/cast_config_delegate_media_router.cc File chrome/browser/ui/ash/cast_config_delegate_media_router.cc (right): https://codereview.chromium.org/2029963002/diff/20001/chrome/browser/ui/ash/cast_config_delegate_media_router.cc#newcode103 chrome/browser/ui/ash/cast_config_delegate_media_router.cc:103: if (sink.name().empty()) On 2016/06/02 16:49:24, amp wrote: > Until ...
4 years, 6 months ago (2016-06-02 17:35:14 UTC) #4
jdufault
Oshima, PTAL. This fixes b/29073993 and provides a temporary fix for b/28691645. This will need ...
4 years, 6 months ago (2016-06-02 17:38:55 UTC) #6
oshima
lgtm
4 years, 6 months ago (2016-06-02 18:13:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029963002/40001
4 years, 6 months ago (2016-06-02 18:14:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-02 18:43:49 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 18:45:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdf25cc62ff3ba880f03e8869f59ddefdc21c89e
Cr-Commit-Position: refs/heads/master@{#397481}

Powered by Google App Engine
This is Rietveld 408576698