Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: base/win/event_trace_consumer_unittest.cc

Issue 202993003: Fix "unreachable code" warnings (MSVC warning 4702) in base/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/expectations/expectation.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/event_trace_consumer_unittest.cc
===================================================================
--- base/win/event_trace_consumer_unittest.cc (revision 258102)
+++ base/win/event_trace_consumer_unittest.cc (working copy)
@@ -155,7 +155,6 @@
if (consumer_thread_.Get() == NULL)
return HRESULT_FROM_WIN32(::GetLastError());
- HRESULT hr = S_OK;
HANDLE events[] = { consumer_ready_, consumer_thread_ };
DWORD result = ::WaitForMultipleObjects(arraysize(events), events,
FALSE, INFINITE);
@@ -172,14 +171,10 @@
if (::GetExitCodeThread(consumer_thread_, &exit_code))
return exit_code;
return HRESULT_FROM_WIN32(::GetLastError());
- break;
}
default:
return E_UNEXPECTED;
- break;
}
-
- return hr;
}
// Waits for consumer_ thread to exit, and returns its exit code.
@@ -237,8 +232,8 @@
return;
}
- ASSERT_HRESULT_SUCCEEDED(controller.EnableProvider(test_provider_,
- TRACE_LEVEL_VERBOSE, 0xFFFFFFFF));
+ ASSERT_HRESULT_SUCCEEDED(controller.EnableProvider(
+ test_provider_, TRACE_LEVEL_VERBOSE, 0xFFFFFFFF));
EtwTraceProvider provider(test_provider_);
ASSERT_EQ(ERROR_SUCCESS, provider.Register());
« no previous file with comments | « base/test/expectations/expectation.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698