Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: base/test/expectations/expectation.cc

Issue 202993003: Fix "unreachable code" warnings (MSVC warning 4702) in base/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/win/event_trace_consumer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/expectations/expectation.h" 5 #include "base/test/expectations/expectation.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include "base/win/windows_version.h" 10 #include "base/win/windows_version.h"
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 139
140 return true; 140 return true;
141 } 141 }
142 142
143 Configuration GetCurrentConfiguration() { 143 Configuration GetCurrentConfiguration() {
144 #if NDEBUG 144 #if NDEBUG
145 return CONFIGURATION_RELEASE; 145 return CONFIGURATION_RELEASE;
146 #else 146 #else
147 return CONFIGURATION_DEBUG; 147 return CONFIGURATION_DEBUG;
148 #endif 148 #endif
149 NOTREACHED();
150 return CONFIGURATION_UNSPECIFIED;
151 } 149 }
152 150
153 Expectation::Expectation() 151 Expectation::Expectation()
154 : configuration(CONFIGURATION_UNSPECIFIED), 152 : configuration(CONFIGURATION_UNSPECIFIED),
155 result(RESULT_PASS) { 153 result(RESULT_PASS) {
156 } 154 }
157 155
158 Expectation::~Expectation() {} 156 Expectation::~Expectation() {}
159 157
160 } // namespace test_expectations 158 } // namespace test_expectations
OLDNEW
« no previous file with comments | « no previous file | base/win/event_trace_consumer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698