Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

chrome/browser/notifications/sync_notifier/synced_notification_app_info_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The SyncedNotificationAppInfoService brings down read only metadata from the
 // sync server with information about the services sending synced notifications.
 
 #include "chrome/browser/notifications/sync_notifier/synced_notification_app_info_service.h"
 
 #include "chrome/browser/browser_process.h"
@@ skipping 24 matching lines @@
 SyncedNotificationAppInfoService::MergeDataAndStartSyncing(
     syncer::ModelType type,
     const syncer::SyncDataList& initial_sync_data,
     scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
     scoped_ptr<syncer::SyncErrorFactory> error_handler) {
   thread_checker_.CalledOnValidThread();
   DCHECK_EQ(syncer::SYNCED_NOTIFICATION_APP_INFO, type);
   syncer::SyncMergeResult merge_result(syncer::SYNCED_NOTIFICATION_APP_INFO);
 
   // There should only be one sync data in the list for this data type.
-  if (initial_sync_data.size() != 1 && initial_sync_data.size() != 0) {
+  if (initial_sync_data.size() > 1) {
     LOG(ERROR) << "Too many app infos over sync";
   }
 
-  for (syncer::SyncDataList::const_iterator it = initial_sync_data.begin();
-       it != initial_sync_data.end();
-       ++it) {
-    const syncer::SyncData& sync_data = *it;
+  // TODO(petewil): Today we can only handle a single object, so we simply check
+  // for a non-empty list.  If in the future we can ever handle more, convert
+  // this whole block to be a loop over all of |initial_sync_data|.
+  if (!initial_sync_data.empty()) {
+    const syncer::SyncData& sync_data = initial_sync_data.front();
     DCHECK_EQ(syncer::SYNCED_NOTIFICATION_APP_INFO, sync_data.GetDataType());
 
     const sync_pb::SyncedNotificationAppInfoSpecifics& specifics =
         sync_data.GetSpecifics().synced_notification_app_info();
 
     // Store our sync data, so GetAllSyncData can give it back later.
     sync_data_ = sync_data;
 
     size_t app_info_count = specifics.synced_notification_app_info_size();
 
     // The SyncedNotificationAppInfo is a repeated field, process each one.
     for (size_t app_info_index = 0;
          app_info_index < app_info_count;
          ++app_info_index) {
       const sync_pb::SyncedNotificationAppInfo app_info(
           specifics.synced_notification_app_info(app_info_index));
 
       ProcessIncomingAppInfoProtobuf(app_info);
     }
-
-    // TODO(petewil): Today we can only handle a single object, so we break
-    // here.  In the future if we can ever handle more, remove the next line.
-    break;
   }
 
   return merge_result;
 }
 
 void SyncedNotificationAppInfoService::StopSyncing(syncer::ModelType type) {
   DCHECK_EQ(syncer::SYNCED_NOTIFICATION_APP_INFO, type);
   // Implementation is not required, since this is not a user selectable sync
   // type.
 }
@@ skipping 150 matching lines @@
 }
 
 // Add a new app info to our data structure.  This takes ownership
 // of the passed in pointer.
 void SyncedNotificationAppInfoService::Add(
     scoped_ptr<SyncedNotificationAppInfo> app_info) {
   sending_service_infos_.push_back(app_info.release());
 }
 
 }  // namespace notifier