third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h - Issue 2029923003: Recursively defining custom elements should not lead to redefinition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

Issue 2029923003: Recursively defining custom elements should not lead to redefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

index b6d98ab1cee403410831c3e29a54a7eb8af56ff2..e8fa2d36f4d792507e3277cb3589bced1e1cc743 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

@@ -30,6 +30,7 @@ public:

CustomElementsRegistry*,

const ScriptValue& constructorScriptValue,

ExceptionState&);

+ ~ScriptCustomElementDefinitionBuilder();

bool checkConstructorIntrinsics() override;

bool checkConstructorNotRegistered() override;

@@ -37,6 +38,9 @@ public:

CustomElementDefinition* build(const CustomElementDescriptor&) override;

private:

+ static ScriptCustomElementDefinitionBuilder* s_stack;

+ ScriptCustomElementDefinitionBuilder* m_prev;

RefPtr<ScriptState> m_scriptState;

Member<CustomElementsRegistry> m_registry;

v8::Local<v8::Value> m_constructorValue;