Replace FWL_HLISTITEM with class IFWL_ListItem {}

Replace FWL_HLISTITEM with class IFWL_ListItem {}

Make CFWL_ classes inherit from IFWL_ListItem.
Replace reinterpret_casts with static_casts.

Committed: https://pdfium.googlesource.com/pdfium/+/ad700c2c1fc3c3843dae71e5982f462e42efc987

[Tom Sepez, 2016-06-02 00:19:29]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-06-02 00:19:29]

Lei, for review.

[Lei Zhang, 2016-06-02 01:14:17]

lgtm

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
File xfa/fwl/lightwidget/cfwl_listbox.cpp (right):

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:46: return
(IFWL_ListItem*)m_ListBoxDP.m_ItemArray.back().get();
Still need the cast?

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:121: return (IFWL_ListItem*)hItem.get();
Ditto

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:140: return
(IFWL_ListItem*)m_ListBoxDP.m_ItemArray[nIndex].get();
Ditto

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:227: return
(IFWL_ListItem*)m_ItemArray[nIndex].get();
Ditto

[dsinclair, 2016-06-02 01:28:57]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-06-02 01:28:58]

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_list...
File xfa/fwl/basewidget/fwl_listboximp.cpp (right):

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_list...
xfa/fwl/basewidget/fwl_listboximp.cpp:262: IFWL_ListItem* hItem =
pData->GetItem(m_pInterface, i);
Should the variables in here be rename to p instead of h? So, pItem?

[Tom Sepez, 2016-06-02 21:03:00]

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_list...
File xfa/fwl/basewidget/fwl_listboximp.cpp (right):

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_list...
xfa/fwl/basewidget/fwl_listboximp.cpp:262: IFWL_ListItem* hItem =
pData->GetItem(m_pInterface, i);
On 2016/06/02 01:28:58, dsinclair wrote:
> Should the variables in here be rename to p instead of h? So, pItem?

Done.

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
File xfa/fwl/lightwidget/cfwl_listbox.cpp (right):

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:46: return
(IFWL_ListItem*)m_ListBoxDP.m_ItemArray.back().get();
On 2016/06/02 01:14:16, Lei Zhang (OOO) wrote:
> Still need the cast?

Done.

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:121: return (IFWL_ListItem*)hItem.get();
On 2016/06/02 01:14:16, Lei Zhang (OOO) wrote:
> Ditto

Done.

https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_li...
xfa/fwl/lightwidget/cfwl_listbox.cpp:140: return
(IFWL_ListItem*)m_ListBoxDP.m_ItemArray[nIndex].get();
On 2016/06/02 01:14:16, Lei Zhang (OOO) wrote:
> Ditto

Done.

[Tom Sepez, 2016-06-02 21:16:34]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-06-02 21:16:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2029923002/#ps20001
(title: "Remove redundant casts, hItem -> pItem")

[commit-bot: I haz the power, 2016-06-02 21:16:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029923002/20001

[commit-bot: I haz the power, 2016-06-02 21:17:44]

Description was changed from

==========
Replace FWL_HLISTITEM with class IFWL_ListItem {}

Make CFWL_ classes inherit from IFWL_ListItem.
Replace reinterpret_casts with static_casts.
==========

to

==========
Replace FWL_HLISTITEM with class IFWL_ListItem {}

Make CFWL_ classes inherit from IFWL_ListItem.
Replace reinterpret_casts with static_casts.

Committed:
https://pdfium.googlesource.com/pdfium/+/ad700c2c1fc3c3843dae71e5982f462e42ef...
==========

[commit-bot: I haz the power, 2016-06-02 21:17:45]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ad700c2c1fc3c3843dae71e5982f462e42ef...