Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2029923002: Replace FWL_HLISTITEM with class IFWL_ListItem {} (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FWL_HLISTITEM with class IFWL_ListItem {} Make CFWL_ classes inherit from IFWL_ListItem. Replace reinterpret_casts with static_casts. Committed: https://pdfium.googlesource.com/pdfium/+/ad700c2c1fc3c3843dae71e5982f462e42efc987

Patch Set 1 #

Total comments: 9

Patch Set 2 : Remove redundant casts, hItem -> pItem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -368 lines) Patch
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 16 chunks +17 lines, -17 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.h View 4 chunks +19 lines, -19 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 1 32 chunks +117 lines, -117 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_listbox.h View 1 3 chunks +22 lines, -21 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.h View 1 2 chunks +18 lines, -20 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.cpp View 1 5 chunks +50 lines, -54 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.h View 1 3 chunks +32 lines, -32 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_listbox.cpp View 1 9 chunks +81 lines, -83 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom Sepez
Lei, for review.
4 years, 6 months ago (2016-06-02 00:19:29 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_listbox.cpp File xfa/fwl/lightwidget/cfwl_listbox.cpp (right): https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_listbox.cpp#newcode46 xfa/fwl/lightwidget/cfwl_listbox.cpp:46: return (IFWL_ListItem*)m_ListBoxDP.m_ItemArray.back().get(); Still need the cast? https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/lightwidget/cfwl_listbox.cpp#newcode121 xfa/fwl/lightwidget/cfwl_listbox.cpp:121: ...
4 years, 6 months ago (2016-06-02 01:14:17 UTC) #3
dsinclair
https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_listboximp.cpp File xfa/fwl/basewidget/fwl_listboximp.cpp (right): https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_listboximp.cpp#newcode262 xfa/fwl/basewidget/fwl_listboximp.cpp:262: IFWL_ListItem* hItem = pData->GetItem(m_pInterface, i); Should the variables in ...
4 years, 6 months ago (2016-06-02 01:28:58 UTC) #5
Tom Sepez
https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_listboximp.cpp File xfa/fwl/basewidget/fwl_listboximp.cpp (right): https://codereview.chromium.org/2029923002/diff/1/xfa/fwl/basewidget/fwl_listboximp.cpp#newcode262 xfa/fwl/basewidget/fwl_listboximp.cpp:262: IFWL_ListItem* hItem = pData->GetItem(m_pInterface, i); On 2016/06/02 01:28:58, dsinclair ...
4 years, 6 months ago (2016-06-02 21:03:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029923002/20001
4 years, 6 months ago (2016-06-02 21:16:45 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 21:17:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ad700c2c1fc3c3843dae71e5982f462e42ef...

Powered by Google App Engine
This is Rietveld 408576698