Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2029903003:
Migrate WaitableEvent to enum-based constructor in completion_event.h (Closed)
|
Created:
4 years, 6 months ago by gab Modified:
4 years, 6 months ago Reviewers:
enne (OOO) CC:
chromium-reviews, cc-bugs_chromium.org, fdoray Base URL:
https://chromium.googlesource.com/chromium/src.git@3_readwritelock Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMigrate WaitableEvent to enum-based constructor in completion_event.h
Not sure why that one was missed by clang-tidy...
BUG=612843
TBR=enne@chromium.org
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/eb8ecd35077892610e593a31c8fd6dc9117520a8
Cr-Commit-Position: refs/heads/master@{#397425}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 17 (9 generated)
Description was changed from ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=danakj@chromium.org ========== to ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
gab@chromium.org changed reviewers: + enne@chromium.org - danakj@chromium.org
TBR enne
The CQ bit was checked by gab@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2034743002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
CC etienne FYI (clang-tidy missed a change I would have expected it to catch..?)
Description was changed from ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029903003/1
On 2016/06/02 14:48:54, gab wrote: > CC etienne FYI (clang-tidy missed a change I would have expected it to catch..?) The question is: where this is used/included? If it was not compiled by clang-tidy, it won't be found. This include is only used by cc/trees/*.h I suspect nothing is linking with your current chrome build?!
On 2016/06/02 14:58:46, etienneb wrote: > On 2016/06/02 14:48:54, gab wrote: > > CC etienne FYI (clang-tidy missed a change I would have expected it to > catch..?) > > The question is: where this is used/included? > If it was not compiled by clang-tidy, it won't be found. > > This include is only used by cc/trees/*.h > I suspect nothing is linking with your current chrome build?! I found the error by compiling "unit_tests chrome browser_tests components_unittests base_unittests" locally (same config used to feed clang-tidy : Linux+Release+component)
Message was sent while issue was closed.
Description was changed from ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Migrate WaitableEvent to enum-based constructor in completion_event.h Not sure why that one was missed by clang-tidy... BUG=612843 TBR=enne@chromium.org NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/eb8ecd35077892610e593a31c8fd6dc9117520a8 Cr-Commit-Position: refs/heads/master@{#397425} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eb8ecd35077892610e593a31c8fd6dc9117520a8 Cr-Commit-Position: refs/heads/master@{#397425} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
