Add token field to ClientSafeBrowsingReportReqeust

chrome/browser/download/download_danger_prompt_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/download/download_danger_prompt.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 15 matching lines @@
 using ::testing::ByRef;
 using ::testing::Eq;
 using ::testing::Return;
 using ::testing::ReturnRef;
 using ::testing::SaveArg;
 using safe_browsing::ClientDownloadResponse;
 using safe_browsing::ClientSafeBrowsingReportRequest;
 using safe_browsing::SafeBrowsingService;
 
 const char kTestDownloadUrl[] = "http://evildownload.com";
+const char kDownloadResponseToken[] = "default_token";
 
 class DownloadDangerPromptTest : public InProcessBrowserTest {
  public:
   DownloadDangerPromptTest()
       : prompt_(nullptr),
         expected_action_(DownloadDangerPrompt::CANCEL),
         did_receive_callback_(false),
         test_safe_browsing_factory_(
             new safe_browsing::TestSafeBrowsingServiceFactory()) {}
 
@@ skipping 16 matching lines @@
     ui_test_utils::NavigateToURLWithDisposition(
         browser(), GURL("about:blank"),
         NEW_FOREGROUND_TAB,
         ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB |
         ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
   }
 
   void SetUpExpectations(
       const DownloadDangerPrompt::Action& expected_action,
       const content::DownloadDangerType& danger_type,
-      const ClientDownloadResponse::Verdict& download_verdict) {
+      const ClientDownloadResponse::Verdict& download_verdict,
+      const std::string& token,
+      bool from_download_api) {
     did_receive_callback_ = false;
     expected_action_ = expected_action;
-    SetUpDownloadItemExpectations(danger_type);
+    SetUpDownloadItemExpectations(danger_type, token);
     SetUpSafeBrowsingReportExpectations(
-        expected_action == DownloadDangerPrompt::ACCEPT, download_verdict);
-    CreatePrompt();
+        expected_action == DownloadDangerPrompt::ACCEPT,
+        download_verdict,
+        token,
+        from_download_api);
+    CreatePrompt(from_download_api);
   }
 
   void VerifyExpectations(bool should_send_report) {
     content::RunAllPendingInMessageLoop();
     // At the end of each test, we expect no more activity from the prompt. The
     // prompt shouldn't exist anymore either.
     EXPECT_TRUE(did_receive_callback_);
     EXPECT_FALSE(prompt_);
 
     if (should_send_report) {
@@ skipping 13 matching lines @@
   void SimulatePromptAction(DownloadDangerPrompt::Action action) {
     prompt_->InvokeActionForTesting(action);
   }
 
   content::MockDownloadItem& download() { return download_; }
 
   DownloadDangerPrompt* prompt() { return prompt_; }
 
  private:
   void SetUpDownloadItemExpectations(
-      const content::DownloadDangerType& danger_type) {
+      const content::DownloadDangerType& danger_type,
+      const std::string& token) {
     EXPECT_CALL(download_, GetFileNameToReportUser()).WillRepeatedly(Return(
         base::FilePath(FILE_PATH_LITERAL("evil.exe"))));
     EXPECT_CALL(download_, GetDangerType()).WillRepeatedly(Return(danger_type));
+    EXPECT_CALL(download_, GetDownloadPingToken())
+        .WillRepeatedly(Return(token));
   }
 
   void SetUpSafeBrowsingReportExpectations(
       bool did_proceed,
-      const ClientDownloadResponse::Verdict& download_verdict) {
+      const ClientDownloadResponse::Verdict& download_verdict,
+      const std::string& token,
+      bool from_download_api) {
     ClientSafeBrowsingReportRequest expected_report;
     expected_report.set_url(GURL(kTestDownloadUrl).spec());
-    expected_report.set_type(
-        ClientSafeBrowsingReportRequest::DANGEROUS_DOWNLOAD_RECOVERY);
+    if (from_download_api)
+      expected_report.set_type(
+          ClientSafeBrowsingReportRequest::DANGEROUS_DOWNLOAD_BY_API);
+    else
+      expected_report.set_type(
+          ClientSafeBrowsingReportRequest::DANGEROUS_DOWNLOAD_RECOVERY);
     expected_report.set_download_verdict(download_verdict);
     expected_report.set_did_proceed(did_proceed);
+    if (!token.empty())
+      expected_report.set_token(token);
     expected_report.SerializeToString(&expected_serialized_report_);
   }
 
-  void CreatePrompt() {
+  void CreatePrompt(bool from_download_api) {
     prompt_ = DownloadDangerPrompt::Create(
         &download_,
         browser()->tab_strip_model()->GetActiveWebContents(),
-        false,
+        from_download_api,
         base::Bind(&DownloadDangerPromptTest::PromptCallback, this));
     content::RunAllPendingInMessageLoop();
   }
 
   void PromptCallback(DownloadDangerPrompt::Action action) {
     EXPECT_FALSE(did_receive_callback_);
     EXPECT_EQ(expected_action_, action);
     did_receive_callback_ = true;
     prompt_ = nullptr;
   }
@@ skipping 25 matching lines @@
       .WillByDefault(Return(browser()->profile()));
   base::FilePath empty_file_path;
   ON_CALL(download(), GetTargetFilePath())
       .WillByDefault(ReturnRef(empty_file_path));
 
   OpenNewTab();
 
   // Clicking the Accept button should invoke the ACCEPT action.
   SetUpExpectations(DownloadDangerPrompt::ACCEPT,
                     content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL,
-                    ClientDownloadResponse::DANGEROUS);
+                    ClientDownloadResponse::DANGEROUS,
+                    kDownloadResponseToken,
+                    false);
   EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(true));
   SimulatePromptAction(DownloadDangerPrompt::ACCEPT);
   VerifyExpectations(true);
 
   // Clicking the Cancel button should invoke the CANCEL action.
   SetUpExpectations(DownloadDangerPrompt::CANCEL,
                     content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT,
-                    ClientDownloadResponse::UNCOMMON);
+                    ClientDownloadResponse::UNCOMMON,
+                    base::EmptyString(),
+                    false);
   EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(true));
   SimulatePromptAction(DownloadDangerPrompt::CANCEL);
   VerifyExpectations(true);
 
   // If the download is no longer dangerous (because it was accepted), the
   // dialog should DISMISS itself.
   SetUpExpectations(DownloadDangerPrompt::DISMISS,
                     content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED,
-                    ClientDownloadResponse::POTENTIALLY_UNWANTED);
+                    ClientDownloadResponse::POTENTIALLY_UNWANTED,
+                    kDownloadResponseToken,
+                    false);
   EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(false));
   download().NotifyObserversDownloadUpdated();
   VerifyExpectations(false);
 
   // If the download is in a terminal state then the dialog should DISMISS
   // itself.
   SetUpExpectations(DownloadDangerPrompt::DISMISS,
                     content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST,
-                    ClientDownloadResponse::DANGEROUS_HOST);
+                    ClientDownloadResponse::DANGEROUS_HOST,
+                    kDownloadResponseToken,
+                    false);
   EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(true));
   EXPECT_CALL(download(), IsDone()).WillRepeatedly(Return(true));
   download().NotifyObserversDownloadUpdated();
   VerifyExpectations(false);
 
   // If the download is dangerous and is not in a terminal state, don't dismiss
   // the dialog.
   SetUpExpectations(DownloadDangerPrompt::ACCEPT,
                     content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT,
-                    ClientDownloadResponse::DANGEROUS);
+                    ClientDownloadResponse::DANGEROUS,
+                    kDownloadResponseToken,
+                    false);
   EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(true));
   EXPECT_CALL(download(), IsDone()).WillRepeatedly(Return(false));
   download().NotifyObserversDownloadUpdated();
   EXPECT_TRUE(prompt());
   SimulatePromptAction(DownloadDangerPrompt::ACCEPT);
   VerifyExpectations(true);
 
   // If the download is not dangerous, no report will be sent.
   SetUpExpectations(DownloadDangerPrompt::ACCEPT,
                     content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
-                    ClientDownloadResponse::SAFE);
+                    ClientDownloadResponse::SAFE,
+                    kDownloadResponseToken,
+                    false);
   SimulatePromptAction(DownloadDangerPrompt::ACCEPT);
   VerifyExpectations(false);
 
   // If the containing tab is closed, the dialog should DISMISS itself.
   OpenNewTab();
   SetUpExpectations(DownloadDangerPrompt::DISMISS,
                     content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL,
-                    ClientDownloadResponse::DANGEROUS);
+                    ClientDownloadResponse::DANGEROUS,
+                    kDownloadResponseToken,
+                    false);
   chrome::CloseTab(browser());
   VerifyExpectations(false);
+
+  // If file is downloaded through download api, a confirm download dialog
+  // instead of a recovery dialog is shown. Clicking the Accept button should
+  // invoke the ACCEPT action, a report will be sent with type
+  // DANGEROUS_DOWNLOAD_BY_API.
+  SetUpExpectations(DownloadDangerPrompt::ACCEPT,
+                    content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL,
+                    ClientDownloadResponse::DANGEROUS,
+                    kDownloadResponseToken,
+                    true);
+  EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(true));
+  SimulatePromptAction(DownloadDangerPrompt::ACCEPT);
+  VerifyExpectations(true);
+
+  // If file is downloaded through download api, a confirm download dialog
+  // instead of a recovery dialog is shown. Clicking the Cancel button should
+  // invoke the CANCEL action, a report will be sent with type
+  // DANGEROUS_DOWNLOAD_BY_API.
+  SetUpExpectations(DownloadDangerPrompt::CANCEL,
+                    content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT,
+                    ClientDownloadResponse::UNCOMMON,
+                    base::EmptyString(),
+                    true);
+  EXPECT_CALL(download(), IsDangerous()).WillRepeatedly(Return(true));
+  SimulatePromptAction(DownloadDangerPrompt::CANCEL);
+  VerifyExpectations(true);
 }